From owner-freebsd-stable@freebsd.org Tue Dec 15 19:48:17 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26DA0A48C37 for ; Tue, 15 Dec 2015 19:48:17 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22e.google.com (mail-pf0-x22e.google.com [IPv6:2607:f8b0:400e:c00::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F14361940; Tue, 15 Dec 2015 19:48:16 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22e.google.com with SMTP id u66so9801535pfb.3; Tue, 15 Dec 2015 11:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LNrudrQ+444R7m9XQbj/kaTWuMB9FgKdCDWpCChcfDc=; b=Poc+Y6DK3mPA1lCgOYOwAx8FpJc2a0doX3Zg8/bJscE1jbHucuJUjnl2DiWsoUepHB NXfEXwj4yvA1R0vQChYz/HluZQL+gdNkQJIOF9LN5V3HZAcTVgdr4ZVN9SQC0QatmIaC 0KCsIKcgXumTbH1gWIvdE3BOAg4lMU5MewhJ4RNDzd4XxOzvNBHfGiSMl98JNvozZxPf lCHBRUDkqy393be9fUdUMh9TKaxQ7hhQBJOS3uYVsO4qTzUiQt/xyN+Cj//HbGuf0gqK fO7wuLsIv9V6WMoPI6GVl63EkWoC9MwsbGR0U0eGqX/0msQMDj9rFU+Pvx8McjLQYQ0K zW7Q== X-Received: by 10.98.0.195 with SMTP id 186mr47609114pfa.130.1450208896697; Tue, 15 Dec 2015 11:48:16 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:b4a3:afbd:5861:d066? ([2601:601:800:126d:b4a3:afbd:5861:d066]) by smtp.gmail.com with ESMTPSA id l87sm3908702pfj.60.2015.12.15.11.48.14 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 Dec 2015 11:48:15 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: make tinderbox broken with LINT-NOINET on ref10-amd64.freebsd.org (if_gif compilation issues) From: NGie Cooper In-Reply-To: <566FF870.7030106@FreeBSD.org> Date: Tue, 15 Dec 2015 11:48:13 -0800 Cc: Mariusz Zaborski , FreeBSD-Stable ML , Warner Losh Content-Transfer-Encoding: quoted-printable Message-Id: <04FF06C6-4A84-436E-B9A7-5DDA2E7DFA48@gmail.com> References: <20151214165111.GA70582@jarvis.whl> <566EF46A.8080704@FreeBSD.org> <20151214165858.GA76268@jarvis.whl> <566FF870.7030106@FreeBSD.org> To: "Andrey V. Elsukov" X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 19:48:17 -0000 > On Dec 15, 2015, at 03:24, Andrey V. Elsukov wrote: >=20 > On 14.12.15 19:58, Mariusz Zaborski wrote: >> On Mon, Dec 14, 2015 at 07:55:06PM +0300, Andrey V. Elsukov wrote: >>> On 14.12.15 19:51, Mariusz Zaborski wrote: >>>> On Mon, Dec 14, 2015 at 06:31:52AM -0800, NGie Cooper wrote: >>>>> Hi Andrey, Just a heads up that LINT-NOINET seems to be broken on >>>>> amd64/i386 with if_gif(4) on stable/10. Could you please fix this?=20= >>>>> Thanks, -NGie >>>> Hi, >>>>=20 >>>> I already found the problem we need to MFC r276224 and r277130. >>>=20 >>> I don't think r277130 is related to this problem. >>> I have this patch and I'm trying to build with them. >> Not with this but after fixing r276224 it will crash in other place = which >> r277130 is fixing. :) >=20 > Actually, I don't think that my patch will work correctly. > opt_inet.h can contain several options in addition to INET. In such = case > the expression >=20 > OPT_INET!=3D cat ${KERNBUILDDIR}/opt_inet.h; echo > .if empty(OPT_INET) >=20 > will always be true. Are you sure merging of r276224 it works as = expected? >=20 > Probably, this patch will work correctly: Would it be a good idea to do: MK_INET_SUPPORT?=3Dno instead of: MK_INET_SUPPORT=3Dno , in the event that someone wanted if_gif support but hadn=92t = configured their kernel yet? Thanks! -NGie=