From owner-freebsd-standards@FreeBSD.ORG Tue Mar 30 12:20:18 2004 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DF1616A4CF for ; Tue, 30 Mar 2004 12:20:18 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 682C843D39 for ; Tue, 30 Mar 2004 12:20:18 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i2UKKIbv055521 for ; Tue, 30 Mar 2004 12:20:18 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i2UKKIbM055520; Tue, 30 Mar 2004 12:20:18 -0800 (PST) (envelope-from gnats) Resent-Date: Tue, 30 Mar 2004 12:20:18 -0800 (PST) Resent-Message-Id: <200403302020.i2UKKIbM055520@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-standards@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Farfeleder Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E03C816A4CE for ; Tue, 30 Mar 2004 12:18:32 -0800 (PST) Received: from bgezal.rise.tuwien.ac.at (bgezal.rise.tuwien.ac.at [128.130.59.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D4BD43D48 for ; Tue, 30 Mar 2004 12:18:32 -0800 (PST) (envelope-from stefan@fafoe.narf.at) Received: from fafoe.narf.at (unknown [212.186.3.235]) by bgezal.rise.tuwien.ac.at (Postfix) with ESMTP id DD98520B5 for ; Tue, 30 Mar 2004 22:18:30 +0200 (CEST) Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.1.42]) by fafoe.narf.at (Postfix) with ESMTP id 5C48540B6; Tue, 30 Mar 2004 22:18:28 +0200 (CEST) Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id A449147B; Tue, 30 Mar 2004 22:18:26 +0200 (CEST) Message-Id: <20040330201826.A449147B@wombat.fafoe.narf.at> Date: Tue, 30 Mar 2004 22:18:26 +0200 (CEST) From: Stefan Farfeleder To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: stefan@fafoe.narf.at Subject: standards/64956: [patch] occasionally fails to define WINT_MIN and WINT_MAX X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Stefan Farfeleder List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2004 20:20:18 -0000 >Number: 64956 >Category: standards >Synopsis: [patch] occasionally fails to define WINT_MIN and WINT_MAX >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 30 12:20:17 PST 2004 >Closed-Date: >Last-Modified: >Originator: Stefan Farfeleder >Release: FreeBSD 5.2-CURRENT i386 >Organization: >Environment: System: FreeBSD wombat.fafoe.narf.at 5.2-CURRENT FreeBSD 5.2-CURRENT #17: Sat Mar 20 15:52:00 CET 2004 stefan@wombat.fafoe.narf.at:/usr/home/stefan/freebsd/obj/usr/home/stefan/freebsd/src/sys/WOMBAT i386 >Description: defines the macros WINT_MIN and WINT_MAX only if WCHAR_MIN is not defined. Including defines WCHAR_MIN but not WINT_MIN and WINT_MAX, so this is clearly wrong. Since is the only header defining those two macros, no test at all is necessary. >How-To-Repeat: $ cat wint_min.c #include #include int i = WINT_MIN; $ c99 -c wint_min.c wint_min.c:3: error: `WINT_MIN' undeclared here (not in a function) $ >Fix: --- wint_min_max.diff begins here --- Index: src/sys/alpha/include/_stdint.h =================================================================== RCS file: /usr/home/ncvs/src/sys/alpha/include/_stdint.h,v retrieving revision 1.1 diff -I.svn -u -r1.1 _stdint.h --- src/sys/alpha/include/_stdint.h 29 Jul 2002 17:41:06 -0000 1.1 +++ src/sys/alpha/include/_stdint.h 30 Mar 2004 19:48:11 -0000 @@ -160,11 +160,11 @@ /* Limits of wchar_t. */ #define WCHAR_MIN INT32_MIN #define WCHAR_MAX INT32_MAX +#endif /* Limits of wint_t. */ #define WINT_MIN INT32_MIN #define WINT_MAX INT32_MAX -#endif #endif /* !defined(__cplusplus) || defined(__STDC_LIMIT_MACROS) */ Index: src/sys/amd64/include/_stdint.h =================================================================== RCS file: /usr/home/ncvs/src/sys/amd64/include/_stdint.h,v retrieving revision 1.2 diff -I.svn -u -r1.2 _stdint.h --- src/sys/amd64/include/_stdint.h 21 Nov 2003 03:02:00 -0000 1.2 +++ src/sys/amd64/include/_stdint.h 30 Mar 2004 19:48:15 -0000 @@ -160,11 +160,11 @@ /* Limits of wchar_t. */ #define WCHAR_MIN INT32_MIN #define WCHAR_MAX INT32_MAX +#endif /* Limits of wint_t. */ #define WINT_MIN INT32_MIN #define WINT_MAX INT32_MAX -#endif #endif /* !defined(__cplusplus) || defined(__STDC_LIMIT_MACROS) */ Index: src/sys/arm/include/_stdint.h =================================================================== RCS file: /usr/home/ncvs/src/sys/arm/include/_stdint.h,v retrieving revision 1.1 diff -I.svn -u -r1.1 _stdint.h --- src/sys/arm/include/_stdint.h 29 Jul 2002 17:41:07 -0000 1.1 +++ src/sys/arm/include/_stdint.h 30 Mar 2004 19:48:19 -0000 @@ -160,11 +160,11 @@ /* Limits of wchar_t. */ #define WCHAR_MIN INT32_MIN #define WCHAR_MAX INT32_MAX +#endif /* Limits of wint_t. */ #define WINT_MIN INT32_MIN #define WINT_MAX INT32_MAX -#endif #endif /* !defined(__cplusplus) || defined(__STDC_LIMIT_MACROS) */ Index: src/sys/i386/include/_stdint.h =================================================================== RCS file: /usr/home/ncvs/src/sys/i386/include/_stdint.h,v retrieving revision 1.1 diff -I.svn -u -r1.1 _stdint.h --- src/sys/i386/include/_stdint.h 29 Jul 2002 17:41:07 -0000 1.1 +++ src/sys/i386/include/_stdint.h 30 Mar 2004 19:48:22 -0000 @@ -160,11 +160,11 @@ /* Limits of wchar_t. */ #define WCHAR_MIN INT32_MIN #define WCHAR_MAX INT32_MAX +#endif /* Limits of wint_t. */ #define WINT_MIN INT32_MIN #define WINT_MAX INT32_MAX -#endif #endif /* !defined(__cplusplus) || defined(__STDC_LIMIT_MACROS) */ Index: src/sys/ia64/include/_stdint.h =================================================================== RCS file: /usr/home/ncvs/src/sys/ia64/include/_stdint.h,v retrieving revision 1.1 diff -I.svn -u -r1.1 _stdint.h --- src/sys/ia64/include/_stdint.h 29 Jul 2002 17:41:08 -0000 1.1 +++ src/sys/ia64/include/_stdint.h 30 Mar 2004 19:48:26 -0000 @@ -160,11 +160,11 @@ /* Limits of wchar_t. */ #define WCHAR_MIN INT32_MIN #define WCHAR_MAX INT32_MAX +#endif /* Limits of wint_t. */ #define WINT_MIN INT32_MIN #define WINT_MAX INT32_MAX -#endif #endif /* !defined(__cplusplus) || defined(__STDC_LIMIT_MACROS) */ Index: src/sys/powerpc/include/_stdint.h =================================================================== RCS file: /usr/home/ncvs/src/sys/powerpc/include/_stdint.h,v retrieving revision 1.1 diff -I.svn -u -r1.1 _stdint.h --- src/sys/powerpc/include/_stdint.h 29 Jul 2002 17:41:16 -0000 1.1 +++ src/sys/powerpc/include/_stdint.h 30 Mar 2004 19:48:30 -0000 @@ -160,11 +160,11 @@ /* Limits of wchar_t. */ #define WCHAR_MIN INT32_MIN #define WCHAR_MAX INT32_MAX +#endif /* Limits of wint_t. */ #define WINT_MIN INT32_MIN #define WINT_MAX INT32_MAX -#endif #endif /* !defined(__cplusplus) || defined(__STDC_LIMIT_MACROS) */ Index: src/sys/sparc64/include/_stdint.h =================================================================== RCS file: /usr/home/ncvs/src/sys/sparc64/include/_stdint.h,v retrieving revision 1.1 diff -I.svn -u -r1.1 _stdint.h --- src/sys/sparc64/include/_stdint.h 29 Jul 2002 17:41:16 -0000 1.1 +++ src/sys/sparc64/include/_stdint.h 30 Mar 2004 19:48:52 -0000 @@ -160,11 +160,11 @@ /* Limits of wchar_t. */ #define WCHAR_MIN INT32_MIN #define WCHAR_MAX INT32_MAX +#endif /* Limits of wint_t. */ #define WINT_MIN INT32_MIN #define WINT_MAX INT32_MAX -#endif #endif /* !defined(__cplusplus) || defined(__STDC_LIMIT_MACROS) */ --- wint_min_max.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: