Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Dec 2019 22:12:22 +0000 (UTC)
From:      Brooks Davis <brooks@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r355965 - stable/11/sys/dev/ata/chipsets
Message-ID:  <201912202212.xBKMCMhw027995@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: brooks
Date: Fri Dec 20 22:12:21 2019
New Revision: 355965
URL: https://svnweb.freebsd.org/changeset/base/355965

Log:
  MFC r355830:
  
  Avoid a tautological bitwise compare.
  
  This looks like a bit of debugging code that sliped into the initial
  import of the sos@ ATA framework. This changes the behavior to omit a
  line of output that appears to have been intended for omission.
  
  Reviewed by:	mav
  Sponsored by:	DARPA, AFRL
  Differential Revision:	https://reviews.freebsd.org/D22845

Modified:
  stable/11/sys/dev/ata/chipsets/ata-promise.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/ata/chipsets/ata-promise.c
==============================================================================
--- stable/11/sys/dev/ata/chipsets/ata-promise.c	Fri Dec 20 22:07:05 2019	(r355964)
+++ stable/11/sys/dev/ata/chipsets/ata-promise.c	Fri Dec 20 22:12:21 2019	(r355965)
@@ -793,7 +793,7 @@ ata_promise_mio_reset(device_t dev)
 	    if (ata_sata_phy_reset(dev, -1, 1)) {
 		u_int32_t signature = ch->hw.softreset(dev, ATA_PM);
 
-		if (1 | bootverbose)
+		if (bootverbose)
         	    device_printf(dev, "SIGNATURE: %08x\n", signature);
 
 		switch (signature >> 16) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912202212.xBKMCMhw027995>