From owner-cvs-src@FreeBSD.ORG Sat Nov 18 20:59:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 82C5516A407; Sat, 18 Nov 2006 20:59:52 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EE8843D6B; Sat, 18 Nov 2006 20:59:46 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kAIKxpgu080541; Sat, 18 Nov 2006 20:59:51 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kAIKxpBG080540; Sat, 18 Nov 2006 20:59:51 GMT (envelope-from kib) Message-Id: <200611182059.kAIKxpBG080540@repoman.freebsd.org> From: Konstantin Belousov Date: Sat, 18 Nov 2006 20:59:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/security/audit audit_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 20:59:52 -0000 kib 2006-11-18 20:59:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/security/audit audit_syscalls.c Log: On RELENG_6, vn_open() will drop Giant aquired for calls into non-MP-safe filesystem if fdx == -1, assuming the in-kernel callers are not MP-safe. On HEAD, vn_open() after rev. 1.240 of sys/kern/vfs_vnops.c would keep the Giant locked when the MPSAFE flag is given. The difference in the API caused the auditctl() syscall code to try to unlock non-locked Giant for non-MP-safe filesystems, for instance, UFS when QUOTA is compiled in. This is direct commit to RELENG_6 to accomodate for RELENG_6' vn_open(). Reported by: Steve Wills (steve at stevenwills com) Reviewed by: rwatson Approved by: re (bmah) X-MFC to RELENG_6_2 after: 3 days Revision Changes Path 1.1.2.5 +2 -2 src/sys/security/audit/audit_syscalls.c