Date: Mon, 6 Oct 2014 10:34:43 +0400 From: Andrej Zverev <az@freebsd.org> To: John Marino <marino@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Bartek Rutkowski <robak@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r370131 - in head/net-mgmt: . nagios-check_dhcp.pl Message-ID: <CAD5bB%2BgVvAL1vaiBi7fmWQr_mtP-OAg__8h7O3=hPO4dJLxZbQ@mail.gmail.com> In-Reply-To: <54323187.7040603@marino.st> References: <201410052140.s95LeUa9030114@svn.freebsd.org> <CAD5bB%2Bg5oUuWUXLpJia7vssd0SjTwn%2B0geRZApPULtQn%2B_gDxQ@mail.gmail.com> <54323187.7040603@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello John,
I don't see why shebangfix can't handle space.
_SHEBANG_REINPLACE_ARGS+= -e
"1s|^\#![[:space:]]*${${lang}_OLD_CMD}|\#!${${lang}_CMD}|"
Even if it can't you can make some handwork to obey framework instead of
making one more way of doing this :-)
About approval, well I first wanted to write my email to Robak and his
mentrors, but after looking previous commits in my mailbox can't find any
sign of them. Sure I know where to look. In this case I was too lazy to
search, my fault.
But anyway, what about LOCALBASE and shebangfix? I think they can be fixed.
If you prefer I can provide patch. Please don't get my email as something
bad, If something can be done better so why not.
On Mon, Oct 6, 2014 at 10:07 AM, John Marino <freebsd.contact@marino.st>
wrote:
> On 10/6/2014 05:35, Andrej Zverev wrote:
> > 2. @${REINPLACE_CMD} -e "s,/usr/bin/perl,${PERL}," ${WRKSRC}/${PORTNAME}
> > <- you can use USES=shebangfix
>
> Be careful with this one -- I made a similar comment and then found out
> the script started with "#! /usr/bin/perl" where the space prevented
> shebangfix from working. This could be a similar situation.
>
> > P.S. Approved by: mentors (implicit) <- not sure about this they both
> > did it, or only one of them and why don't write who they are?
>
> Robak has implicit approval from both mentors for most commits. He's
> been given guidelines on when he should seek explicit approval. I'd
> says "mentors" (plural) is appropriate.
>
> As for why not written, dunno. Obviously it can be looked up. I think
> the key message is that explicit approval was not obtained, not
> repeating who the mentors are which each commit (which doesn't change).
> As one of his mentors, I didn't have a problem with the message.
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD5bB%2BgVvAL1vaiBi7fmWQr_mtP-OAg__8h7O3=hPO4dJLxZbQ>