Date: Sat, 27 Jan 2024 17:09:47 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Dirk Meyer <dinoex@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Re: git: 50c28128f2ef - main - comms/lrzsz: do not link with libbe(3) Message-ID: <dkhar4r2lwi2ij55u4a3cxtwu7b62ypsrq5jx2ciewjgoo3zy4@mzzmgteccx6c> In-Reply-To: <ZbUoV9oNcFo76-pI@FreeBSD.org> References: <202401271546.40RFktRR070097@gitrepo.freebsd.org> <ZbUoV9oNcFo76-pI@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--frx3rzjaol7usapb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 27, 2024 at 03:59:19PM +0000, Alexey Dokuchaev wrote: > On Sat, Jan 27, 2024 at 03:46:55PM +0000, Dirk Meyer wrote: > > commit 50c28128f2ef196caf67619027335a44b005641d > >=20 > > comms/lrzsz: do not link with libbe(3) > >=20 > > Submitted by: Dmitry Lukhtionov > > PR: 276613 >=20 > To make the attribution more transparent, the actual patch was > conceived by eugen@ (Eugene Grosbein). If only it was actually a patch and not some sed stunt... We really need to stop doing this, a patch or a sed will both break if the file gets modified, but a patch actually shows the intent of what is being removed and makes it easier to update, wheras here, it removes 140 lines starting at some string. I know the submitter submitted that exact sed line. The reason we have committers and not a script merging random patches is so that we adapt the submissions to fit in with our practices. --=20 Mathieu Arnold --frx3rzjaol7usapb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmW1KspfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb4U6AwArqdghZTbaCGYPs6rwQiR9fYtt05+LwjjyFJxZofnY5xF0WoS3HkxScv4 aoqytu1HXaaEZkJr0YXZbyE1lyaAL6kk7SsDMW33N1zqv4WGPyMO+HsbvTIZ0xi0 GMFqwBLbcq/PYbXInyb4uEm8VMt/z7pZmin8VfHLg0tuqVwl6+dtIqIQ/zuKHbAd AcXFIUgdF6KZZ9URQJ2tyUseknODmsdGurO9cgtzBkh5kML3gvAjeeIPzbBz5x27 n/6Q9V76aWJafqtjE6/2D7uNbHWWMAfhzKj5MFOONULBw+IcJQ0JtuGQGad/DI8T er6lJ3FMVjZskhSEgX0KZ4SXwAv4sKkK+B8GE1DSDYtzI39A9Lo3uB5ONWu/D5PJ RzifXxk+hIaaTe/amY6w3t5DcQR4cUKpd0JOQc6OjxXcHE7A2LobImR5pY+b4tm1 WHiWQ8aG3AWr9lmXsmn9uY9IzbZzdHxAk6G+ouH1wiZ5k55g+L9Ta6qkLLnxzUbq gMXaWmEH =7Po3 -----END PGP SIGNATURE----- --frx3rzjaol7usapb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dkhar4r2lwi2ij55u4a3cxtwu7b62ypsrq5jx2ciewjgoo3zy4>