From owner-freebsd-scsi@FreeBSD.ORG  Tue Jul 10 16:37:12 2012
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BF4F3106564A
	for <freebsd-scsi@freebsd.org>; Tue, 10 Jul 2012 16:37:11 +0000 (UTC)
	(envelope-from aboyer@averesystems.com)
Received: from mail.averesystems.com
	(50-73-27-109-cpennsylvania.hfc.comcastbusiness.net [50.73.27.109])
	by mx1.freebsd.org (Postfix) with ESMTP id 873CD8FC17
	for <freebsd-scsi@freebsd.org>; Tue, 10 Jul 2012 16:37:11 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by mail.averesystems.com (Postfix) with ESMTP id B12C048064B;
	Tue, 10 Jul 2012 12:37:14 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.averesystems.com
Received: from mail.averesystems.com ([127.0.0.1])
	by localhost (mail.averesystems.com [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id VCjxvPf-U+ND; Tue, 10 Jul 2012 12:37:10 -0400 (EDT)
Received: from riven.arriad.com (206.193.225.214.nauticom.net
	[206.193.225.214])
	by mail.averesystems.com (Postfix) with ESMTPSA id 0C6064804AE;
	Tue, 10 Jul 2012 12:37:09 -0400 (EDT)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=windows-1252
From: Andrew Boyer <aboyer@averesystems.com>
In-Reply-To: <1341340916.3370.6.camel@powernoodle.corp.yahoo.com>
Date: Tue, 10 Jul 2012 12:37:03 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <2936EBFD-CA1E-4EC4-9790-80D1A5DC5567@averesystems.com>
References: <909AAC62-7BB4-43E7-B04B-27466B038A07@averesystems.com>
	<1341340916.3370.6.camel@powernoodle.corp.yahoo.com>
To: Sean Bruno <seanbru@yahoo-inc.com>
X-Mailer: Apple Mail (2.1278)
Cc: "freebsd-scsi@freebsd.org" <freebsd-scsi@freebsd.org>
Subject: Re: [patch] MFI should set bio_resid on command failure
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jul 2012 16:37:12 -0000


On Jul 3, 2012, at 2:41 PM, Sean Bruno wrote:

> On Tue, 2012-07-03 at 06:47 -0700, Andrew Boyer wrote:
>> When an MFI command fails, the driver needs to set bio->bio_resid so =
that the upper levels notice.  Otherwise we see commands silently =
failing leading to data corruption.  This mirrors dadone().
>>=20
>> -Andrew
>>=20
>> Index: sys/dev/mfi/mfi_disk.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- sys/dev/mfi/mfi_disk.c	(revision 238071)
>> +++ sys/dev/mfi/mfi_disk.c	(working copy)
>> @@ -298,6 +298,7 @@
>> 	hdr =3D bio->bio_driver1;
>>=20
>> 	if (bio->bio_flags & BIO_ERROR) {
>> +		bio->bio_resid =3D bio->bio_bcount;
>> 		if (bio->bio_error =3D=3D 0)
>> 			bio->bio_error =3D EIO;
>> 		disk_err(bio, "hard error", -1, 1);
>>=20
>> --------------------------------------------------
>> Andrew Boyer	aboyer@averesystems.com
>>=20
>=20
> This looks right to me.  It mirrors the behavior in =
mfi_disk_strategy()
> as well.
>=20
> Sean
>=20

Anyone interested in committing?  (And MFC'ing to stable/8=85)

-Andrew

--------------------------------------------------
Andrew Boyer	aboyer@averesystems.com