From owner-svn-src-stable-11@freebsd.org Wed Dec 20 07:55:48 2017 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91BB2E9D3F6; Wed, 20 Dec 2017 07:55:48 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5BC9B27D8; Wed, 20 Dec 2017 07:55:48 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vBK7tl9r095719; Wed, 20 Dec 2017 07:55:47 GMT (envelope-from delphij@FreeBSD.org) Received: (from delphij@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vBK7tlpg095718; Wed, 20 Dec 2017 07:55:47 GMT (envelope-from delphij@FreeBSD.org) Message-Id: <201712200755.vBK7tlpg095718@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: delphij set sender to delphij@FreeBSD.org using -f From: Xin LI Date: Wed, 20 Dec 2017 07:55:47 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r327021 - stable/11/usr.bin/su X-SVN-Group: stable-11 X-SVN-Commit-Author: delphij X-SVN-Commit-Paths: stable/11/usr.bin/su X-SVN-Commit-Revision: 327021 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 07:55:48 -0000 Author: delphij Date: Wed Dec 20 07:55:47 2017 New Revision: 327021 URL: https://svnweb.freebsd.org/changeset/base/327021 Log: MFC r326561: Use strlcpy(). Modified: stable/11/usr.bin/su/su.c Directory Properties: stable/11/ (props changed) Modified: stable/11/usr.bin/su/su.c ============================================================================== --- stable/11/usr.bin/su/su.c Wed Dec 20 07:43:32 2017 (r327020) +++ stable/11/usr.bin/su/su.c Wed Dec 20 07:55:47 2017 (r327021) @@ -275,9 +275,9 @@ main(int argc, char *argv[]) if (asme) { if (pwd->pw_shell != NULL && *pwd->pw_shell != '\0') { /* must copy - pwd memory is recycled */ - shell = strncpy(shellbuf, pwd->pw_shell, + strlcpy(shellbuf, pwd->pw_shell, sizeof(shellbuf)); - shellbuf[sizeof(shellbuf) - 1] = '\0'; + shell = shellbuf; } else { shell = _PATH_BSHELL;