From owner-svn-ports-head@freebsd.org  Tue Nov 28 16:44:45 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8293DE3A42;
 Tue, 28 Nov 2017 16:44:45 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C85586DD17;
 Tue, 28 Nov 2017 16:44:45 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 13997365; Tue, 28 Nov 2017 16:44:45 +0000 (UTC)
Date: Tue, 28 Nov 2017 16:44:45 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Torsten Zuehlsdorff <tz@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r455053 - in head/devel/gitaly: . files
Message-ID: <20171128164445.GD43542@FreeBSD.org>
References: <201711281606.vASG6M0F052282@repo.freebsd.org>
 <20171128161054.GA36486@FreeBSD.org>
 <e4e15791-7852-e665-fe15-b29b1113ce61@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e4e15791-7852-e665-fe15-b29b1113ce61@FreeBSD.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2017 16:44:46 -0000

On Tue, Nov 28, 2017 at 05:19:53PM +0100, Torsten Zuehlsdorff wrote:
> On 28.11.2017 17:10, Alexey Dokuchaev wrote:
> > On Tue, Nov 28, 2017 at 04:06:22PM +0000, Torsten Zuehlsdorff wrote:
> >> New Revision: 455053
> >> URL: https://svnweb.freebsd.org/changeset/ports/455053
> >>
> >> Log:
> >>    devel/gitaly: Update config example
> >>    
> >>    Add more sections for referenced software using
> >>    there correct paths.
> >>    
> >>    Submitted by: Matthias Fechner <idefix@fechner.net>
> >> [...]
> >> @@ -1,5 +1,5 @@
> >> ---- config.toml.example.orig	2017-09-01 10:24:38 UTC
> >> -+++ config.toml.example
> >> +--- config.toml.example.orig	2017-10-28 10:50:48.245547000 +0200
> >> ++++ config.toml.example	2017-10-28 10:56:00.467310000 +0200
> > 
> > Could you please try to retain original (correct) timestamps in the
> > patches?  It's too late now, but ``make makepatch'' would be a nice
> > thing to add to your repertoire in the future.  Thanks,
> 
> As you may noticed the patch isn't from me.

It's part of our job as committers to fix shortcomings of submitted
patches.

> Maybe i should have enforced it, but i didn't see any benefit in
> another round.

It helps to recude repochurn and makes cleaner diffs.  That's why it
(makepatch) was put together in the first place.

./danfe