From owner-freebsd-wireless@FreeBSD.ORG Wed Mar 7 20:18:41 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 547B8106564A for ; Wed, 7 Mar 2012 20:18:41 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id D14D48FC0A for ; Wed, 7 Mar 2012 20:18:40 +0000 (UTC) Received: by eaaf13 with SMTP id f13so2511521eaa.13 for ; Wed, 07 Mar 2012 12:18:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id :x-gm-message-state; bh=Er4Jpdj/SEaozeEE3hvL85bFix/Bh9l/+h6vQjEXS2I=; b=foDm/MuX0tdpq5LvS8id5ZgOAfIS4x92+0CWW1VyZu2y8LDkAhj9oTV8PMtrtnTHje kSdcRpvhRIstGWcrRb+0lfZ93ThIrB2kGaiwWBkos7D7ArgmdElYwb8U+OGNcMhk3HkU M6/4JQEO8rrM6Sakhm7UY+N01Vp54+T4N0IF/xnevjP21rWWwN/9zuXHrV+7O4iNbRQz FQntStp0zgE/eDCvPT8JMqaZYPgdmpKQ2EHsa+SlOzKNgs9+cByp1nnz+y6xtfP1cQ2a I4LIVZJDa2IoD9qh/skbKJOCGgdN5A0LXIjFbGESscSj3b+7zoi+nLiU6kQ7o4ZPhXSs nq0w== Received: by 10.213.4.131 with SMTP id 3mr803042ebr.22.1331151514327; Wed, 07 Mar 2012 12:18:34 -0800 (PST) Received: from amy.lab.techwires.net (dslb-088-065-223-042.pools.arcor-ip.net. [88.65.223.42]) by mx.google.com with ESMTPS id n55sm50909816eef.6.2012.03.07.12.18.31 (version=SSLv3 cipher=OTHER); Wed, 07 Mar 2012 12:18:33 -0800 (PST) Sender: Bernhard Schmidt From: Bernhard Schmidt To: Adrian Chadd Date: Wed, 7 Mar 2012 21:18:47 +0100 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <201203052314.22050.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203072118.47751.bschmidt@freebsd.org> X-Gm-Message-State: ALoCoQnY5SDkk+nT2ItKL/LEsl4+Z2mTvo6YkMTS0aVKPuOsMeouAPcr1rVRDODVwg/8bHZycgfI Cc: freebsd-current@freebsd.org, Mitsuru IWASAKI , freebsd-wireless@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 20:18:41 -0000 On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote: > Hi, > > I'd rather you didn't commit iwi_update_mcast() unless you absolutely > know that the NIC doesn't need to be notified of multicast group > membership changes. If so, please commit that as a separate fix. Oh well, iwi(4) receives multicast frames just fine, they are discarded somewhere else though last time I've checked, another offtopic issue ;) > I'll look at iwi later and give you feedback on that particular change. I did look into this once for ipw it was I guess, the firmware doesn't support filtering based on addresses so everything one could achieve here is enable/disable filtering of all multicast frames. Check iwi_configuration.enable_multicast_filtering, which is a bool actually not an uint8_t. -- Bernhard