From nobody Wed Dec 3 02:38:53 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dLhfQ44Rjz6JfqV for ; Wed, 03 Dec 2025 02:38:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dLhfQ0HZCz3tRk for ; Wed, 03 Dec 2025 02:38:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764729534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vRvDgoP4nJVK4UqUGidNDF/2O6RAKzVX+XfilbDg/EM=; b=mSrerb/SQhMPXa6e5S1yqfdoYFqyBAl2huI4t5TMj0J9DfgeZGTp3s4OlXQZwIPKDpHthA gfoPot020boLGWgrMeQZ6JBm69AubeKpsq5eMAGTCV4rZc9S91+WihNvmiOpIsutemkWUu btFzbJOe3azI+Br23CfmWsSkZ7hRatw1gnb7V4El8jSiOXLUHUN9o8hHBr3qmi6z5qj7Bg q3DGFv9XVDTbcqQVvbi8/eahYR6fCdrtHhan9DR7cEWv93SvoJyJ11WVXUWr9SjvM+0mRD L9wO4hGxaCfbTmdWtxBS8PPv/Vp+wJx2vko8cJXu2A3aGTxi4ogC6ueMtbE00g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764729534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vRvDgoP4nJVK4UqUGidNDF/2O6RAKzVX+XfilbDg/EM=; b=KY6MGSpsmR9Me7fLHN1vPAcebKevTDPHffKWR/ufLQ7FHBwhKxl1PDEcAXPs5yjzpcsno1 oxFypa5coxyFj7SyAlCmAGggG8sqizd7XNQ6rsbuJzNUeCwjcFTBcS58lD5NGHvr73XD8r Us5JgSelauhT9Y0f3OO4IwGs3B32PQJzULUdxg3S33PTwf/bs0E8qzMDN3V4zuDJDfTSOx Fu/RhRvpEpdxL24PKOjTzdzH6btInAq69Nbmo3O3cOUCNDwyUHnhxQ95aEio2A+rt3B/UQ p+xxoIgyiK3iTJu8OKZ6+8M/cOPIGBbGtvz9wE8W11f8yhtBFJORUyEMjlsK6A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764729534; a=rsa-sha256; cv=none; b=u8/OSG9vw/QBx27n7u356qs4IYTFu2JvZ837Dl/2ejgxPhBGKSS2Q+kXlZugdokQfhgi59 E9ZAMuU/f71h8GkFTIE8brdBghXX0euEx0522xVnsGSz5SLI6S+A5YjQNC0iBjfPgHpr90 PQ7F1IKxoURTdK6slvUYHdYfkOAyoedGxNvEwM35SoQvuqZGP+r4d/XF0ECvOI9lS3kVUV FtnCljAQGpR+udmFo1SHjCmbX8CEQZg6ZKV+9xZjuSnje0dbQtguKzAAAkwQy6hBuKweaS ZZYXDngXCz3JyYQEl146xwh09gMp8+4Wpei80Q5jtaGa8Ectlr167pL+4DRzTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dLhfP6LJZz3qF for ; Wed, 03 Dec 2025 02:38:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2f86e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 03 Dec 2025 02:38:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jose Luis Duran Subject: git: 02a810d9b4cc - stable/13 - strfmon: Fix negative sign handling for C locale List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 02a810d9b4cc8b3cd30d7e6bfe01b5e3c68ee492 Auto-Submitted: auto-generated Date: Wed, 03 Dec 2025 02:38:53 +0000 Message-Id: <692fa2bd.2f86e.32b7985b@gitrepo.freebsd.org> The branch stable/13 has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=02a810d9b4cc8b3cd30d7e6bfe01b5e3c68ee492 commit 02a810d9b4cc8b3cd30d7e6bfe01b5e3c68ee492 Author: Jose Luis Duran AuthorDate: 2025-11-26 20:34:56 +0000 Commit: Jose Luis Duran CommitDate: 2025-12-03 02:35:56 +0000 strfmon: Fix negative sign handling for C locale If the locale's positive_sign and negative_sign values would both be returned by localeconv() as empty strings, strfmon() shall behave as if the negative_sign value was the string "-". This occurs with the C locale. The implementation previously assigned "0" to sign_posn (parentheses around the entire string); now it assigns it to "1" (sign before the string) when it is undefined (CHAR_MAX). Austin Group Defect 1199[1] is applied, changing the requirements for the '+' and '(' flags. [1]: https://www.austingroupbugs.net/view.php?id=1199 Reviewed by: kib MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D53913 (cherry picked from commit cf85e7034ad5640b18a3b68d6b291b7bf89bfc80) --- lib/libc/stdlib/strfmon.c | 2 +- lib/libc/tests/stdlib/strfmon_test.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/libc/stdlib/strfmon.c b/lib/libc/stdlib/strfmon.c index 2dfc7d99510e..7a4e1093fc4d 100644 --- a/lib/libc/stdlib/strfmon.c +++ b/lib/libc/stdlib/strfmon.c @@ -458,7 +458,7 @@ __setup_vars(int flags, char *cs_precedes, char *sep_by_space, char *sign_posn, if (*sep_by_space == CHAR_MAX) *sep_by_space = 0; if (*sign_posn == CHAR_MAX) - *sign_posn = 0; + *sign_posn = 1; } static int diff --git a/lib/libc/tests/stdlib/strfmon_test.c b/lib/libc/tests/stdlib/strfmon_test.c index 7fc0afc9e229..a112fbf65c1d 100644 --- a/lib/libc/tests/stdlib/strfmon_test.c +++ b/lib/libc/tests/stdlib/strfmon_test.c @@ -206,8 +206,8 @@ ATF_TC_BODY(strfmon_plus_or_parenthesis, tc) { "%(i", "C", "[123.45] [(123.45)]" }, { "%(n", "en_US.UTF-8", "[$123.45] [($123.45)]" }, { "%(i", "en_US.UTF-8", "[USD123.45] [(USD123.45)]" }, - { "%n", "C", "[123.45] [(123.45)]" }, /* XXX */ - { "%i", "C", "[123.45] [(123.45)]" }, /* XXX */ + { "%n", "C", "[123.45] [-123.45]" }, + { "%i", "C", "[123.45] [-123.45]" }, { "%n", "en_US.UTF-8", "[$123.45] [-$123.45]" }, { "%i", "en_US.UTF-8", "[USD123.45] [-USD123.45]" }, }; @@ -254,7 +254,7 @@ ATF_TC_BODY(strfmon_l, tc) const char *locale; const char *expected; } tests[] = { - { "C", "[ **1234.57 ] [ **1234.57 ]" }, /* XXX */ + { "C", "[ **1234.57] [ **1234.57]" }, { "de_DE.UTF-8", "[ **1234,57 €] [ **1.234,57 EUR]" }, { "en_GB.UTF-8", "[ £**1234.57] [ GBP**1,234.57]" }, };