From owner-cvs-ports@FreeBSD.ORG Thu Nov 16 23:18:35 2006 Return-Path: X-Original-To: cvs-ports@freebsd.org Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1860E16A403; Thu, 16 Nov 2006 23:18:35 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 27B3543D55; Thu, 16 Nov 2006 23:18:33 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.186] (vpn-client-186.marcuscom.com [10.2.1.186]) by creme-brulee.marcuscom.com (8.13.8/8.13.8) with ESMTP id kAGNJNHP021729; Thu, 16 Nov 2006 18:19:24 -0500 (EST) (envelope-from marcus@marcuscom.com) Message-ID: <455CF1E9.1040709@marcuscom.com> Date: Thu, 16 Nov 2006 18:19:05 -0500 From: Joe Marcus Clarke Organization: MarcusCom, Inc. User-Agent: Thunderbird 1.5.0.8 (Macintosh/20061025) MIME-Version: 1.0 To: Jean-Yves Lefort References: <200611161949.kAGJnDr5074353@repoman.freebsd.org> <20061116211550.GA68969@xor.obsecurity.org> <20061116225709.13d06775.jylefort@FreeBSD.org> <20061116222509.GA70087@xor.obsecurity.org> <20061117000224.91f0f80c.jylefort@FreeBSD.org> In-Reply-To: <20061117000224.91f0f80c.jylefort@FreeBSD.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on creme-brulee.marcuscom.com Cc: security-team@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org, freebsd-gnome-team@marcuscom.com, Kris Kennaway , cvs-ports@freebsd.org Subject: Re: cvs commit: ports/sysutils/hal Makefile ports/sysutils/hal/files patch-hal.conf.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2006 23:18:35 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jean-Yves Lefort wrote: > On Thu, 16 Nov 2006 17:25:09 -0500 > Kris Kennaway wrote: > >> On Thu, Nov 16, 2006 at 10:57:09PM +0100, Jean-Yves Lefort wrote: >>> On Thu, 16 Nov 2006 16:15:50 -0500 >>> Kris Kennaway wrote: >>> >>>> On Thu, Nov 16, 2006 at 07:49:13PM +0000, Jean-Yves Lefort wrote: >>>>> jylefort 2006-11-16 19:49:13 UTC >>>>> >>>>> FreeBSD ports repository >>>>> >>>>> Modified files: >>>>> sysutils/hal Makefile >>>>> Added files: >>>>> sysutils/hal/files patch-hal.conf.in >>>>> Log: >>>>> Give wheel group members the same rights as operator group members. >>>> This violates the definition of the wheel group, FYI (even though it >>>> might seem expedient), so it can be viewed as a weakening of the >>>> security model. Prior to this commit, the only right that the wheel >>>> group had was the ability to attempt to su to root, if the user knows >>>> the password. >>> The commit message should have been: >>> >>> Give wheel group members the same HAL rights (mount a volume, etc) as >>> operator group members. >> Yes, I understood. My point was that this was precisely the role of >> the operator group, so you've combined two entities which previously >> had distinct security behaviours. > > Makes sense. However since the decision was discussed collectively > I'll wait for other opinions before reverting. I see Kris' point. While this isn't a privilege escalation per se, we are violating the separation of privilege, and it would probably be a good idea to back this out. Joe - -- PGP Key : http://www.marcuscom.com/pgp.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFXPHob2iPiv4Uz4cRAsanAKCYkatHSeT+lupZ4WutXvStjt6gVQCfasGP x+lsSWEYOqrzllxO87o2AEU= =yjGr -----END PGP SIGNATURE-----