From owner-freebsd-bugs@FreeBSD.ORG  Mon May 10 08:40:16 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 55D9E16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 10 May 2004 08:40:16 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C8EBA43D41
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 10 May 2004 08:40:15 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i4AFeFct080027	for <freebsd-bugs@freefall.freebsd.org>;
	Mon, 10 May 2004 08:40:15 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4AFeFGL080026;
	Mon, 10 May 2004 08:40:15 -0700 (PDT)
	(envelope-from gnats)
Date: Mon, 10 May 2004 08:40:15 -0700 (PDT)
Message-Id: <200405101540.i4AFeFGL080026@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dmitry Morozovsky <marck@rinet.ru>
Subject: Re: bin/66474: [patch] add jitter to cron(8) to smooth load spikes
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Dmitry Morozovsky <marck@rinet.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 May 2004 15:40:16 -0000

The following reply was made to PR bin/66474; it has been noted by GNATS.

From: Dmitry Morozovsky <marck@rinet.ru>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/66474: [patch] add jitter to cron(8) to smooth load spikes
Date: Mon, 10 May 2004 19:39:49 +0400 (MSD)

 On Mon, 10 May 2004 FreeBSD-gnats-submit@FreeBSD.org wrote:
 
 Minor correction [do_command.c]: sleep part moved earlier to improve logging.
 
 Sincerely,
 D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
 ------------------------------------------------------------------------
 *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru ***
 ------------------------------------------------------------------------
 
 Index: usr.sbin/cron/cron/do_command.c
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/cron/cron/do_command.c,v
 retrieving revision 1.15.2.6
 diff -u -r1.15.2.6 do_command.c
 --- usr.sbin/cron/cron/do_command.c	22 Jun 2003 18:49:39 -0000	1.15.2.6
 +++ usr.sbin/cron/cron/do_command.c	10 May 2004 15:36:10 -0000
 @@ -166,6 +166,11 @@
  		Debug(DPROC, ("[%d] grandchild process Vfork()'ed\n",
  			      getpid()))
 
 +		if (Jitter != 0) {
 +			srandom(getpid());
 +			sleep(random() % Jitter);
 +		}
 +
  		/* write a log message.  we've waited this long to do it
  		 * because it was not until now that we knew the PID that
  		 * the actual user command shell was going to get and the