From owner-svn-ports-all@FreeBSD.ORG Mon Jan 13 00:20:40 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49152B7D; Mon, 13 Jan 2014 00:20:40 +0000 (UTC) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [IPv6:2a00:1450:400c:c05::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 650D81ED9; Mon, 13 Jan 2014 00:20:39 +0000 (UTC) Received: by mail-wi0-f180.google.com with SMTP id d13so101971wiw.1 for ; Sun, 12 Jan 2014 16:20:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=n3euWURSyvdZnlPdFklq3u+fIgWlfC2QOx7U+fFn9UQ=; b=Mdj5yfHSEngbb8HX3qVs/AYbMd/boidVwKrSzzRRUgryc7xilHZVvqL0T0BfbQv2qQ roEJE5TGuRxjCHIAvZeLUjUoty2sDraJuYfAAd45ld5VAKXZh9+6kYZ6piFk5/d/86kE fYC2jMAEtLHtKXO8e7ukx6n+Og099bFWWGMA7uMSu3bUW7kWRBG6vG67kfogYruhkuwy Y4tlW0RfarTKzN14uBRreeth3OYuwRTO+lNvBF2AuOsTB3tIX+tWjcChtHjx7v4RxEzB Umvzfy/9sn+ZUad7xD4lUFN5N0jWZw98AjZQQgGN0UGOfo09cHFdJ6c5Nx8oI3Nnhl9q 8yzA== X-Received: by 10.194.174.4 with SMTP id bo4mr670708wjc.62.1389572437870; Sun, 12 Jan 2014 16:20:37 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id ot9sm10089339wjc.0.2014.01.12.16.20.36 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 12 Jan 2014 16:20:37 -0800 (PST) Sender: Baptiste Daroussin Date: Mon, 13 Jan 2014 01:20:35 +0100 From: Baptiste Daroussin To: Chris Rees Subject: Re: svn commit: r339550 - in head/Mk: . Uses Message-ID: <20140113002034.GM97375@ithaqua.etoilebsd.net> References: <201401122116.s0CLG6Wn016253@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q8dntDJTu318bll0" Content-Disposition: inline In-Reply-To: <201401122116.s0CLG6Wn016253@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 00:20:40 -0000 --q8dntDJTu318bll0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 12, 2014 at 09:16:06PM +0000, Chris Rees wrote: > Author: crees > Date: Sun Jan 12 21:16:06 2014 > New Revision: 339550 > URL: http://svnweb.freebsd.org/changeset/ports/339550 >=20 > Log: > Strip postgresql code out of bsd.database.mk, and introduce USES=3Dpgsq= l. > =20 > New syntax: > =20 > # Depend on postgresql-client > USES=3D pgsql > =20 > # Depend on postgresql-client at least 9.2 > USES=3D pgsql:9.2+ > =20 > #Depend on postgresql-server at least 9.0 > USES=3D pgsql:9.0+ > WANT_PGSQL=3D server > =20 > Postgresql now supports DEFAULT_VERSIONS, and please note that the > version syntax now includes dots(!); i.e. before it was 90, now 9.0 > =20 > Reviewed by: ade, silence from pgsql@ >=20 It is broken in multiple parts first WANT_PGSQL is checked even when not de= fined resulting multiple lines like: /usr/ports/Mk/Uses/pgsql.mk" line 128: Malformed conditional (${WANT_PGSQL:= M${:Ucontrib}}) if a port only defines USES=3Dpgsql If the first is fixed then the version is not properly defined resulting in= a dependency like: /usr/ports/databases/postgresql-client which doesn't exists. For this kind of change a portmgr review would have been nice and an exp-run even better. regards, Bapt --q8dntDJTu318bll0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLTMVIACgkQ8kTtMUmk6EwA9wCeOdxBGweh6asHyQ3Xv2ZTvpqC zKcAniK1A0qOjyxq7KpvHSSSe0aWvHIP =RBGb -----END PGP SIGNATURE----- --q8dntDJTu318bll0--