From owner-svn-src-all@FreeBSD.ORG Sun Mar 16 21:15:10 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 83954741; Sun, 16 Mar 2014 21:15:10 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5DF455E5; Sun, 16 Mar 2014 21:15:10 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s2GLF2P9090879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 16 Mar 2014 14:15:03 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s2GLF2OH090878; Sun, 16 Mar 2014 14:15:02 -0700 (PDT) (envelope-from jmg) Date: Sun, 16 Mar 2014 14:15:02 -0700 From: John-Mark Gurney To: Mark R V Murray Subject: Re: svn commit: r263218 - in head: lib/libcrypt lib/libmd sys/conf sys/crypto/sha2 Message-ID: <20140316211501.GE32089@funkthat.com> References: <201403160143.s2G1hOV8093665@svn.freebsd.org> <08A216A5-BE59-4505-AA13-2B7E026DB56A@grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08A216A5-BE59-4505-AA13-2B7E026DB56A@grondar.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Sun, 16 Mar 2014 14:15:03 -0700 (PDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Mar 2014 21:15:10 -0000 Mark Murray wrote this message on Sun, Mar 16, 2014 at 17:24 +0000: > I haven?t looked at this closely, but if you?ve dropped support for sha256, then sys/dev/random/... can?t use it :-( Please read closer... To many things would break if sha256 was really removed... > On 16 Mar 2014, at 01:43, John-Mark Gurney wrote: > > replace the kernel's version w/ cperciva's implementation... In all > > my tests, it is faster ~20%, even on an old IXP425 533MHz it is ~45% > > faster... This is partly due to loop unrolling, so the code size does > > significantly increase... I do plan on committing a version that > > rolls up the loops again for smaller code size for embedded systems > > where size is more important than absolute performance (it'll save ~6k > > code)... > > > > The kernel implementation is now shared w/ userland's libcrypt and > > libmd... > > > > We drop support for sha256 from sha2.c, so now sha2.c only contains > > sha384 and sha512... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."