From owner-cvs-src@FreeBSD.ORG Fri Jun 10 01:20:52 2005 Return-Path: <owner-cvs-src@FreeBSD.ORG> X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D63C16A41C for <cvs-src@freebsd.org>; Fri, 10 Jun 2005 01:20:52 +0000 (GMT) (envelope-from ups@freebsd.org) Received: from smtp.speedfactory.net (talon.speedfactory.net [66.23.216.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4901343D1F for <cvs-src@freebsd.org>; Fri, 10 Jun 2005 01:20:51 +0000 (GMT) (envelope-from ups@freebsd.org) Received: (qmail 23741 invoked from network); 10 Jun 2005 02:16:42 +0000 Received: from 66-23-216-49.clients.speedfactory.net (HELO palm.tree.com) (66.23.216.49) by smtp.speedfactory.net with AES256-SHA encrypted SMTP; 10 Jun 2005 02:16:42 +0000 Received: from [127.0.0.1] (ups@localhost.tree.com [127.0.0.1]) by palm.tree.com (8.12.10/8.12.10) with ESMTP id j5A1KdpP096012; Thu, 9 Jun 2005 21:20:39 -0400 (EDT) (envelope-from ups@freebsd.org) From: Stephan Uphoff <ups@freebsd.org> To: John Baldwin <john@baldwin.cx> In-Reply-To: <692e14e0d72d5737f1c12f3c8def892d@baldwin.cx> References: <200506091943.j59Jh8H3058277@repoman.freebsd.org> <692e14e0d72d5737f1c12f3c8def892d@baldwin.cx> Content-Type: text/plain Message-Id: <1118366438.27369.45017.camel@palm> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Thu, 09 Jun 2005 21:20:38 -0400 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_switch.c sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 10 Jun 2005 01:20:52 -0000 On Thu, 2005-06-09 at 19:25, John Baldwin wrote: > On Jun 9, 2005, at 12:43 PM, Stephan Uphoff wrote: > > > ups 2005-06-09 19:43:08 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_switch.c sched_4bsd.c > > Log: > > Lots of whitespace cleanup. > > Fix for broken if condition. > > > > Submitted by: nate@ > > What was broken about the if test? The intention was that when > FULL_PREEMPTION was off, we only preempt if the destination thread is > an ithread or if the current thread is an idle priority thread. I was under the impression that we never preempt the idle thread but did not investigate closer. Is it save to preempt the idle thread on x86 when it does its ACPI C-state magic? > I think you've changed it so that we never preempt if the current thread > is an idle thread now, which is very bad. I took out explicit calls to > mi_switch() in the page zeroing thread in reliance on the behavior that > we always preempt an idle priority thread. I will take a look later today. If we can preempt the idle thread I am all for it. Stephan