From owner-freebsd-current@FreeBSD.ORG Sat Nov 20 10:00:38 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0966A1065670; Sat, 20 Nov 2010 10:00:38 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id A24BE8FC16; Sat, 20 Nov 2010 10:00:36 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA26867; Sat, 20 Nov 2010 12:00:35 +0200 (EET) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1PJkFH-0000iT-3P; Sat, 20 Nov 2010 12:00:35 +0200 Message-ID: <4CE79C42.6000103@freebsd.org> Date: Sat, 20 Nov 2010 12:00:34 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: John Baldwin References: <4CE2771F.8020109@freebsd.org> <201011160827.11628.jhb@freebsd.org> <4CE6A3B4.2080604@freebsd.org> <201011191158.19118.jhb@freebsd.org> In-Reply-To: <201011191158.19118.jhb@freebsd.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, Pawel Jakub Dawidek Subject: removing tq_name [Was: taskqueue_create() name parameter lieftime] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Nov 2010 10:00:38 -0000 on 19/11/2010 18:58 John Baldwin said the following: > On Friday, November 19, 2010 11:20:04 am Andriy Gapon wrote: >> BTW, tq_name doesn't seem to be used anywhere at all. >> Perhaps just drop it? But still could be useful in a debugger, though. > > If it's not used anywhere I would just drop it. > struct taskqueue is defined privately in sys/kern/subr_taskqueue.c and tq_name is used "write-only" in _taskqueue_create(). So, no use for tq_name at all? -- Andriy Gapon