Date: Sat, 8 May 1999 18:36:26 +0200 (CEST) From: dan@obluda.cz To: FreeBSD-gnats-submit@freebsd.org Subject: ports/11593: bug in sources of package tac_plus-2.1 Message-ID: <199905081636.SAA10538@dan-h.fio.cz>
next in thread | raw e-mail | index | archive | help
>Number: 11593
>Category: ports
>Synopsis: minor bug when config file not found in tacacsd
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat May 8 14:00:04 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 3.1-RELEASE i386
>Organization:
Obludarium
>Environment:
no specific environment
package "tac_plus-2.1 installed"
>Description:
Segmentation fault when configuration file not found.
See the code in the "fix" section:
if (cf...==NULL) { ... fclose(cf) ... }
The segmentation fault is caused by fclose(NULL) ...
>How-To-Repeat:
Start tacacsd with nonexistent configuration file.
>Fix:
The original publisher, Cisco systems, no longer offer and maintain
tacacs sources, so we should patch existing sources rather than ask original
publisher to correct it's sources ...
Apply this patch to source from the package is compiled from:
*** config.c.ORIG Fri May 7 22:49:55 1999
--- config.c Fri May 7 23:24:33 1999
***************
*** 1212,1218 ****
if ((cf = fopen(cfile, "r")) == NULL) {
report(LOG_ERR, "read_config: fopen() error for file %s %s, exiting",
cfile, sys_errlist[errno]);
- fclose(cf);
return (1);
}
if (parse_decls() || sym_error) {
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199905081636.SAA10538>