From owner-freebsd-bugs@FreeBSD.ORG Wed Aug 22 07:00:16 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E76C516A419 for ; Wed, 22 Aug 2007 07:00:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D805513C45B for ; Wed, 22 Aug 2007 07:00:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l7M70GQk055606 for ; Wed, 22 Aug 2007 07:00:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l7M70GYc055605; Wed, 22 Aug 2007 07:00:16 GMT (envelope-from gnats) Date: Wed, 22 Aug 2007 07:00:16 GMT Message-Id: <200708220700.l7M70GYc055605@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: vehemens Cc: Subject: Re: kern/114688: [drm] RADEON/AIGLX/DRM Problem X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: vehemens List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2007 07:00:17 -0000 The following reply was made to PR kern/114688; it has been noted by GNATS. From: vehemens To: bug-followup@freebsd.org Cc: Subject: Re: kern/114688: [drm] RADEON/AIGLX/DRM Problem Date: Tue, 21 Aug 2007 23:50:07 -0700 The previous code change was only tested in the git branch, and I fumbled modifying it for the freebsd branch. This revised patch has been tested using the 7.0 driver code. --- drm_drv.c.orig 2006-09-07 16:04:47.000000000 -0700 +++ drm_drv.c 2007-08-21 21:47:08.000000000 -0700 @@ -711,6 +711,8 @@ return EINVAL; } +if (--priv->refs == 0) { + if (dev->driver.preclose != NULL) dev->driver.preclose(dev, filp); @@ -786,7 +788,7 @@ dev->buf_pgid = 0; #endif /* __NetBSD__ || __OpenBSD__ */ - if (--priv->refs == 0) { +// if (--priv->refs == 0) { if (dev->driver.postclose != NULL) dev->driver.postclose(dev, priv); TAILQ_REMOVE(&dev->files, priv, link);