From owner-freebsd-current@FreeBSD.ORG Sun Apr 24 15:02:15 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0BC0816A4CE; Sun, 24 Apr 2005 15:02:15 +0000 (GMT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 0978843D31; Sun, 24 Apr 2005 15:02:14 +0000 (GMT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie ([134.226.81.10] helo=walton.maths.tcd.ie) by salmon.maths.tcd.ie with SMTP id ; 24 Apr 2005 16:02:13 +0100 (BST) Date: Sun, 24 Apr 2005 16:02:11 +0100 From: David Malone To: Matthew Sullivan Message-ID: <20050424150211.GA87520@walton.maths.tcd.ie> References: <426426AE.2060406@uq.edu.au> <20050420084413.GA27304@walton.maths.tcd.ie> <42663EA1.3020409@uq.edu.au> <426A3F49.6090203@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <426A3F49.6090203@uq.edu.au> User-Agent: Mutt/1.5.6i Sender: dwmalone@maths.tcd.ie cc: freebsd-current@freebsd.org cc: andre@freebsd.org Subject: Re: DF (Don't frag) issues X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Apr 2005 15:02:15 -0000 On Sat, Apr 23, 2005 at 10:27:53PM +1000, Matthew Sullivan wrote: > Ok well thanks to Andrew @ Supernews and a lot of debugging it appears > there is a bug.... > > sys/netinet/ip_icmp.c: line 440 > if (!mtu) > mtu = ip_next_mtu(mtu, 1); > Problem is ip_next_mtu will always return 0 when called with (0, 1) ... I think this might be a bug, but Andre would know better. Andre - it looks to me as if the first argument to ip_next_mtu here should be the current MTU for the path, but it is being set to the mtu from the ICMP message, which (in this case) is zero. (This is in the code that has just been moved to tcp_ctlinput.) > Apparently the gateway should be suggesting a MTU value for use.... the > gateway is also FreeBSD 5.3 so something needs fixing .. :-/ Are you using ip fast forwarding on the gateway? It calculates the size that is put into the ICMP message in a slightly different way to the other forwrd path. David.