From owner-cvs-all Mon Feb 24 10:21:18 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D58A37B405 for ; Mon, 24 Feb 2003 10:21:15 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 9633B43FA3 for ; Mon, 24 Feb 2003 10:21:13 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 62354 invoked by uid 1000); 24 Feb 2003 18:20:34 -0000 Date: Mon, 24 Feb 2003 10:20:34 -0800 (PST) From: Nate Lawson To: phk@phk.freebsd.dk Cc: Alfred Perlstein , Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c In-Reply-To: <30346.1046075295@critter.freebsd.dk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN Content-Transfer-Encoding: 8BIT Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 24 Feb 2003 phk@phk.freebsd.dk wrote: > In message <20030224082427.GL27224@elvis.mu.org>, Alfred Perlstein writes: > >> It børks a diskless machine, I posted the details to current@ some days ago. > > > >No, I realized relatively quickly what had gone wrong once someone > >posted a backtrace, I think it was scott. > > > >I also explained to scott why the ordering is needed. Right now he > >has rebroken the mp safety of filedescs so instead of a problem that's > >quite easy to find we have broken code that's racey and can lead to > >crashes. > > Well, if given the choice between something which works most of the time > on all the machines, and something which breaks some of the machines > totally all of the time, I prefer the former until the true fix can > be found. Plus a big XXX comment so this doesn't drift away. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message