From owner-cvs-src@FreeBSD.ORG Fri Apr 8 18:15:54 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14CDF16A531 for ; Fri, 8 Apr 2005 18:15:54 +0000 (GMT) Received: from mail26.sea5.speakeasy.net (mail26.sea5.speakeasy.net [69.17.117.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1432D43D58 for ; Fri, 8 Apr 2005 18:15:53 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 23467 invoked from network); 8 Apr 2005 18:15:52 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 8 Apr 2005 18:15:52 -0000 Received: from roboboy.corp.weather.com (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j38IFHt6089924; Fri, 8 Apr 2005 14:15:43 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "Poul-Henning Kamp" Date: Fri, 8 Apr 2005 12:37:13 -0400 User-Agent: KMail/1.8 References: <19069.1112973882@critter.freebsd.dk> In-Reply-To: <19069.1112973882@critter.freebsd.dk> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200504081237.17789.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: Gleb Smirnoff cc: cvs-all@FreeBSD.org cc: Bruce Evans cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2005 18:15:54 -0000 On Friday 08 April 2005 11:24 am, Poul-Henning Kamp wrote: > In message <20050409002141.V48108@delplex.bde.org>, Bruce Evans writes: > >On Fri, 8 Apr 2005, Gleb Smirnoff wrote: > >> glebius 2005-04-08 14:14:09 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/kern kern_mutex.c > >> Log: > >> Add additional newline to debug.mutex.prof.stats header, so that > >> column names are printed exactly above the columns. > > > >This is bogus, as is the existence of sysctls that format data (*). > > > >(*) Formatted output is not too bad for sysctls in the debug tree, but > >for general-purpose sysctls it is just a bug. > > I disagree. It's a lot easier to parse a structured binary blob than to parse formatted text so that you can display it differently. Note that I would consider XML ala GEOM to be more of the blob style since the whitespace isn't significant. It should be up to userland to do whatever formatting of data is required. For small things like 'current timecounter' or 'list of valid CPU frequencies' simple strings with space delimiting is probably fine though. Trying to format complex data into multiple lines with columns and headers doesn't belong in the kernel outside of ddb IMO. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org