From owner-freebsd-current@FreeBSD.ORG  Thu Sep 29 18:07:01 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CD48D16A41F
	for <freebsd-current@freebsd.org>; Thu, 29 Sep 2005 18:07:01 +0000 (GMT)
	(envelope-from jhb@FreeBSD.org)
Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 30FB643D49
	for <freebsd-current@freebsd.org>; Thu, 29 Sep 2005 18:07:00 +0000 (GMT)
	(envelope-from jhb@FreeBSD.org)
Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by
	mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8)
	id <B433c31050000>; Thu, 29 Sep 2005 14:23:01 -0400
From: John Baldwin <jhb@FreeBSD.org>
To: freebsd-current@freebsd.org
Date: Thu, 29 Sep 2005 13:03:39 -0400
User-Agent: KMail/1.8
References: <34cb7c8405092815247dc89bf6@mail.gmail.com>
	<1127978233.3383.12.camel@berloga.shadowland>
In-Reply-To: <1127978233.3383.12.camel@berloga.shadowland>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-6"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200509291303.41181.jhb@FreeBSD.org>
Cc: Alex Lyashkov <shadow@psoft.net>, Peter Edwards <peadar.edwards@gmail.com>
Subject: Re: biodone panics
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2005 18:07:01 -0000

On Thursday 29 September 2005 03:17 am, Alex Lyashkov wrote:
> > > biodone(struct bio *bp)
> > > {
> > >         void (*done)(struct bio *);
> > >
> > >         mtx_lock(&bdonelock);
> > >         bp->bio_flags |= BIO_DONE;
> > >         done = bp->bio_done
> > >         if (done == NULL)
> > >                 wakeup(bp);
> > >         mtx_unlock(&bdonelock);
> > >         if (done != NULL)
> > >                 bp->bio_done(bp);
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> posible it should be
> if(done != NULL)
> 	done(bp);
> ?

Note that since he only does the wakeup of done is NULL, so I think it's ok as 
is.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org