From owner-svn-ports-head@FreeBSD.ORG Mon Nov 4 02:56:46 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E109DD0B; Mon, 4 Nov 2013 02:56:45 +0000 (UTC) (envelope-from danilogondolfo@gmail.com) Received: from mail-yh0-x235.google.com (mail-yh0-x235.google.com [IPv6:2607:f8b0:4002:c01::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7468A223F; Mon, 4 Nov 2013 02:56:45 +0000 (UTC) Received: by mail-yh0-f53.google.com with SMTP id z20so739179yhz.26 for ; Sun, 03 Nov 2013 18:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6rIey6yWe5wEz7smhJPyoRmTEruL8od4xoTJvLoGECU=; b=WmAAzq7XNUdawkQ/A1C5++kIhPXMUaxq4J9ncb6iSbC57ZGyVzATc/7Af30g8QiDbS BqsvWWAmmkegFS+cvGo+Ckxy+e2DU/QXlbShBda3V4mgf9Ku23cGD2QxFN8cgfwkWnXz YW05Yi4ccafebIvh1mMLBGcst9N+ZBWmT6+y2xJ+ogLw/sDXmHGS4qLaWV9udLw6wyYl XDPNw6AaO6OEUzej4gpepyV6FfRVCOMvnTtOSn5Vpg3H7RcFayaQBl1wKHkglvGlmNFn FvSKuH2UOj1hFpHTkhNsQ6PX0AWAqIUcKW/wrc8prYcR2FFadm/GKba8m8/Y0goMk58j Jupg== X-Received: by 10.236.61.194 with SMTP id w42mr11957188yhc.2.1383533804506; Sun, 03 Nov 2013 18:56:44 -0800 (PST) Received: from [192.168.0.100] ([179.217.197.68]) by mx.google.com with ESMTPSA id g25sm23844093yhg.6.2013.11.03.18.56.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 03 Nov 2013 18:56:43 -0800 (PST) Sender: =?UTF-8?Q?Danilo_Eg=C3=AAa_Gondolfo?= Message-ID: <52770E14.3010901@freebsd.org> Date: Mon, 04 Nov 2013 01:01:40 -0200 From: "Danilo E. Gondolfo" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Tijl Coosemans Subject: Re: svn commit: r332635 - head/lang/yap/files References: <201311031811.rA3IBULH080088@svn.freebsd.org> <20131103204842.20bc5aa7@kalimero.tijl.coosemans.org> In-Reply-To: <20131103204842.20bc5aa7@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2013 02:56:46 -0000 On 11/03/13 17:48, Tijl Coosemans wrote: > On Sun, 3 Nov 2013 18:11:30 +0000 (UTC) Danilo Egea Gondolfo wrote: >> Author: danilo >> Date: Sun Nov 3 18:11:29 2013 >> New Revision: 332635 >> URL: http://svnweb.freebsd.org/changeset/ports/332635 >> >> Log: >> - Fix build with clang on i386 >> >> Added: >> head/lang/yap/files/patch-H__absmi.h (contents, props changed) >> Modified: >> head/lang/yap/files/patch-library__dialect__swi__fli__blobs.c >> head/lang/yap/files/patch-packages__swi-minisat2__C__SolverTypes.h >> >> Added: head/lang/yap/files/patch-H__absmi.h >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/lang/yap/files/patch-H__absmi.h Sun Nov 3 18:11:29 2013 (r332635) >> @@ -0,0 +1,11 @@ >> +--- ./H/absmi.h.orig 2013-11-02 21:11:04.000000000 -0200 >> ++++ ./H/absmi.h 2013-11-02 21:11:12.000000000 -0200 >> +@@ -74,7 +74,7 @@ >> + * Use bp as PREG for X86 machines * >> + ***************************************************************/ >> + #if defined(IN_ABSMI_C) >> +-register struct yami* P1REG asm ("bp"); /* can't use yamop before Yap.h */ >> ++struct yami* P1REG asm ("bp"); /* can't use yamop before Yap.h */ > > Have you runtested this? Because this expects the ebp register to > hold the value of P1REG and this change does not guarantee that. > Clang does not support global register variables at all so if you > cannot disable this code it has to be compiled with gcc. > You're right. Despite it works with the small programs that I've tested, I changed the semantics of the code (from this "mov value,%ebp" to this "movl value,0x8049604". I'll change it to build with GCC. Thanks for the report. Danilo.