From owner-freebsd-alpha Tue Dec 18 14:46:50 2001 Delivered-To: freebsd-alpha@freebsd.org Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (Postfix) with ESMTP id 99E1B37B405 for ; Tue, 18 Dec 2001 14:46:43 -0800 (PST) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id XAA00832; Tue, 18 Dec 2001 23:46:33 +0100 (CET) Received: (from j@localhost) by uriah.heep.sax.de (8.11.6/8.11.6) id fBIMN8500153; Tue, 18 Dec 2001 23:23:08 +0100 (MET) (envelope-from j) Date: Tue, 18 Dec 2001 23:23:08 +0100 From: Joerg Wunsch To: Jake Burkholder Cc: Adam Kranzel , alpha@FreeBSD.ORG Subject: Re: Kernel builds broken? Message-ID: <20011218232308.A97821@uriah.heep.sax.de> Reply-To: Joerg Wunsch References: <20011217083319.25adda22.adam@blacktabby.org> <20011217120232.E39205@locore.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011217120232.E39205@locore.ca>; from jake@locore.ca on Mon, Dec 17, 2001 at 12:02:32PM -0500 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org As Jake Burkholder wrote: > It looks like the ifdefs to skip some of the code for non-i386 are > broken. > > #if _MACHINE_ARCH == i386 in fd_probe() should be #ifdef __i386__. I've reverted it to #ifdef __i386__ now. Still, i think this is the wrong way, since it's now testing for a particular CPU type, not for a machine type. (Or do we have __pc98__ on the PC98?) IMHO, FreeBSD/Alpha should be fixed instead to not define _MACHINE_ARCH to be equal i386. has something like: #ifndef _MACHINE #define _MACHINE alpha #endif #ifndef _MACHINE_ARCH #define _MACHINE_ARCH alpha #endif Hmm, i wouldn't expect this to also be equal to i386, but i cannot find where alpha, i386, ia64 etc. are actually defined. -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message