Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Dec 2001 23:23:08 +0100
From:      Joerg Wunsch <j@uriah.heep.sax.de>
To:        Jake Burkholder <jake@locore.ca>
Cc:        Adam Kranzel <adam@blacktabby.org>, alpha@FreeBSD.ORG
Subject:   Re: Kernel builds broken?
Message-ID:  <20011218232308.A97821@uriah.heep.sax.de>
In-Reply-To: <20011217120232.E39205@locore.ca>; from jake@locore.ca on Mon, Dec 17, 2001 at 12:02:32PM -0500
References:  <20011217083319.25adda22.adam@blacktabby.org> <20011217120232.E39205@locore.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
As Jake Burkholder wrote:

> It looks like the ifdefs to skip some of the code for non-i386 are
> broken.
> 
> #if _MACHINE_ARCH == i386 in fd_probe() should be #ifdef __i386__.

I've reverted it to #ifdef __i386__ now.  Still, i think this is the
wrong way, since it's now testing for a particular CPU type, not for a
machine type.  (Or do we have __pc98__ on the PC98?)  IMHO,
FreeBSD/Alpha should be fixed instead to not define _MACHINE_ARCH to
be equal i386.

<machine/param.h> has something like:

#ifndef _MACHINE
#define _MACHINE        alpha
#endif
#ifndef _MACHINE_ARCH
#define _MACHINE_ARCH   alpha
#endif

Hmm, i wouldn't expect this to also be equal to i386, but i cannot
find where alpha, i386, ia64 etc. are actually defined.

-- 
cheers, J"org               .-.-.   --... ...--   -.. .  DL8DTL

http://www.sax.de/~joerg/                        NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011218232308.A97821>