From owner-freebsd-current@freebsd.org  Wed Aug  2 07:15:06 2017
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 497E6DC8092
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Wed,  2 Aug 2017 07:15:06 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 6A3A97CE8F;
 Wed,  2 Aug 2017 07:15:05 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA20401;
 Wed, 02 Aug 2017 10:14:58 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1dcnru-000Pr9-3R; Wed, 02 Aug 2017 10:14:58 +0300
Subject: Re: zfs.ko no longer loads after r320156: unresolved symbol:
 abd_is_linear
To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>,
 John Baldwin <jhb@FreeBSD.org>
Cc: FreeBSD Current <freebsd-current@FreeBSD.org>
References: <780A67EE-C3F1-46E5-A213-E253B710338E@gmail.com>
 <d948a8c3-7bdb-e4cf-40e0-5e148b58554a@FreeBSD.org>
 <79082534.uzyizLL08l@ralph.baldwin.cx>
 <B16DFAFC-916B-4319-8FE1-D84C6C8D6961@gmail.com>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <ae4900b5-97cc-112a-714f-a9140d4a1726@FreeBSD.org>
Date: Wed, 2 Aug 2017 10:14:01 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <B16DFAFC-916B-4319-8FE1-D84C6C8D6961@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 07:15:06 -0000

On 02/08/2017 04:00, Ngie Cooper (yaneurabeya) wrote:
> 
>> On Aug 1, 2017, at 09:21, John Baldwin <jhb@freebsd.org> wrote:
>>
>> On Tuesday, August 01, 2017 09:47:41 AM Andriy Gapon wrote:
>>> On 01/08/2017 02:31, Ngie Cooper wrote:
>>>> Hi,
>>>> 	I tried upgrading my host from 11.1-STABLE to 12.0-CURRENT, and it didn’t work because abd_is_linear is an undefined symbol (it exists in sys/conf/files, but not sys/modules/zfs/Makefile). I tried adding abd.c to sys/modules/zfs/Makefile and it didn’t immediately fix my compilation problem (ran into a linker error instead).
>>>> 	If it isn’t fixed in the next few hours I’ll try my hand at fixing the problem.
>>>
>>> I am not sure what exact problem you have...
>>> abd.c should be added to the list of source files via
>>> .include "${SUNW}/uts/common/Makefile.files"
>>>
>>> Perhaps something to do with "inline"...
>>
>> Oh, yes.  If you use -fno-inline-funcs or the like.  I forgot to
>> send this to Andriy earlier, but here is the fix I'm using:
>>
>> https://github.com/freebsd/freebsd/commit/574dc95cf8272e16f6d44aff6cb4e08dede08886
> 
> 	Unfortunately… this is head, verbatim, which means that the bug still exists.
> 	This gives me an idea of where I should look though.

The URL indeed suggests that the change should be in head, but it's not there as
far as I can tell.  I never saw it being committed.


-- 
Andriy Gapon