From owner-cvs-src@FreeBSD.ORG Fri Apr 9 10:39:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 350C016A4CE for ; Fri, 9 Apr 2004 10:39:09 -0700 (PDT) Received: from mail01.svc.cra.dublin.eircom.net (mail01.svc.cra.dublin.eircom.net [159.134.118.17]) by mx1.FreeBSD.org (Postfix) with SMTP id 9430743D64 for ; Fri, 9 Apr 2004 10:39:08 -0700 (PDT) (envelope-from peadar@freebsd.org) Received: (qmail 96293 messnum 3378113 invoked from network[83.70.89.2/83-70-89-2.bas1.mvw.galway.eircom.net]); 9 Apr 2004 17:39:07 -0000 Received: from 83-70-89-2.bas1.mvw.galway.eircom.net (HELO freebsd.org) (83.70.89.2) by mail01.svc.cra.dublin.eircom.net (qp 96293) with SMTP; 9 Apr 2004 17:39:07 -0000 Message-ID: <4076DFB7.8040508@freebsd.org> Date: Fri, 09 Apr 2004 18:39:03 +0100 From: Peter Edwards User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040214 X-Accept-Language: en, en-us MIME-Version: 1.0 To: Nate Lawson References: <20040409152753.148A716A500@hub.freebsd.org> <20040409102528.C48723@root.org> In-Reply-To: <20040409102528.C48723@root.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_linker.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2004 17:39:09 -0000 Hi Nate, Nate Lawson wrote: >On Fri, 9 Apr 2004, Peter Edwards wrote: > > >>peadar 2004/04/09 08:27:38 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/kern kern_linker.c >> Log: >> Plug minor memory leak of module_t structures when unloading a file >> from the kernel. >> >> Reviewed By: Doug Rabson (dfr@) >> >> Revision Changes Path >> 1.110 +3 -1 src/sys/kern/kern_linker.c >> >> > >Excellent! In stress testing some attach/detach routines with >load/unload, I noticed memory allocation slowly increasing but couldn't >find a problem with my driver. Are there any other observable leaks? > >-Nate > > > As far as I can tell, that was the only leak. I was updating NFS client/server to allow safe loads/unloads, and with the patch, 2 minutes running this: > while true > do > kldload nfsclient > kldunload nfsclient > done made no noticable difference to the wired memory reported in top, or any of the "InUse" counts from vmstat -m.