From owner-svn-src-head@freebsd.org Wed May 30 10:41:24 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62654F7F546; Wed, 30 May 2018 10:41:24 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-qt0-x22b.google.com (mail-qt0-x22b.google.com [IPv6:2607:f8b0:400d:c0d::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E4D8A7B869; Wed, 30 May 2018 10:41:23 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-qt0-x22b.google.com with SMTP id h2-v6so22565674qtp.7; Wed, 30 May 2018 03:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ose0IVVcbrEkU0gB1/zBBmaoSjncVbTDEeC3dS1EDq4=; b=Xd3YyJGglhGMicTUJY8du3fxvT5N32Kn5BezEeXf1hGj8gYpSSz0mJq3ZqZNRAURpr 7pNraUZj6Xuvz9vRjLazTzSitIxGLMUsaz1+rDucG9mATS4u33KCrquCHVhc6gqQF7Mr uSrSrQOgRKixBsjY4cBXijZIxEvuoRwUMLuXfyd9EOUQOQdzUW0FegbaWc1afR4t64aC 46YE9T1wP0Qft1nvnhGdwYj1xMtwzy9Jejx/wx2lsr0drqDHtafhoFO/0WJRLse4YM9t MqzcbWgrVRpa3yk6YsOoLRwk1rNVmOFNq3V0VMCBThwgeYFfMUJRYZfs1SAYFnMpWnYa 4RnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ose0IVVcbrEkU0gB1/zBBmaoSjncVbTDEeC3dS1EDq4=; b=KnV2qPo9Y+tLnpm06Q8hxWSkFsmKEN0+JY31lF66zIUuPDXAupxlJf8D62cln9WzaF taTBENi8BoXVwfpO94a6tCcgJ1ppArpYcYeJLxdlUHUjc6GJM563xUVWZ0Jc6COJo/MD VLPN4gOTGfrXYyq2lCDCxf1MJ563X8tQd62ojURMsHxCUjCvCIevvUZiGv2XdGlKJu1H DbKJLGTIq3PkmF74+14FG06Org2WPxDO40A8ZJ1em4cyw6FPiWDxiC40CDUFMZFdCU+h 8Vbv6Y8epWSGbxLxC4jU0nYpsiAiLHfNMNJZ0QwPa24Nfj28iLpESaU2IiXt7cu9jKN1 cAaA== X-Gm-Message-State: APt69E2/zP/FRW0SYNNYcZeD2sqQrhtYS6HNiJZlB2QEIT9l/XZ7CgIf WzH67p6gGsENGLpabX8srFlj5xcNqY0UI0iBsgo= X-Google-Smtp-Source: ADUXVKKNe1+zsMmT520ZzzjxE22atISHfgwobbXiAgidqdbUuXITncrfXcc58jmWi6eCInkFtjC/IG0qNZ8dRzODatU= X-Received: by 2002:aed:3ed8:: with SMTP id o24-v6mr1944295qtf.177.1527676883434; Wed, 30 May 2018 03:41:23 -0700 (PDT) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 2002:a0c:accf:0:0:0:0:0 with HTTP; Wed, 30 May 2018 03:41:22 -0700 (PDT) In-Reply-To: References: <201805280812.w4S8CI56046943@repo.freebsd.org> <383666b1-06a9-ac96-812f-c602c8e5e5af@selasky.org> <21342cd6-bf7e-263f-f077-2e073fe9ebef@selasky.org> <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> <56e03042-872c-36df-4fea-d22a09d7ffca@selasky.org> From: Antoine Brodin Date: Wed, 30 May 2018 10:41:22 +0000 X-Google-Sender-Auth: gIWed1uitpr6QW5L2P0W4GnAzKE Message-ID: Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool To: Hans Petter Selasky Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 10:41:24 -0000 On Wed, May 30, 2018 at 9:42 AM, Hans Petter Selasky wrote: > On 05/30/18 11:00, Antoine Brodin wrote: >> >> On Wed, May 30, 2018 at 8:20 AM, Hans Petter Selasky >> wrote: >>> >>> On 05/30/18 10:02, Antoine Brodin wrote: >>>> >>>> >>>> Could the pcap/pcap.h header be fixed instead with #ifdef HAVE_REMOTE >>>> as it previously had? >>> >>> >>> >>> The HAVE_REMOTE was removed upstream: >>> >>> >>> https://github.com/the-tcpdump-group/libpcap/commit/a372536befc9b1ee1d355058daa2eb9f66aa0c59#diff-46964bcbd8e8a5cec9a75c66ab26a97b >>> >>> What do you think? Shall we re-add it to base? > > > Hi, >> >> Either hide remote packet capture functions from the header or enable >> remote capture functions? > > > This feature is disabled by default for UNIX. > >> Note that net/p5-Net-Pcap will fail to build with libpcap from ports >> too when libpcap from ports is updated to version 1.9.0 (pre-release). > > > No, libpcap from ports has own header files and libraries and does not use > anything from libpcap in base. > > Enabling remote packet capture in libcap won't solve the build failure. > > The right solution from my point of view is to extend the BUILD_DEPENDS and > CFLAGS and LDFLAGS like shown: > > BUILD_DEPENDS= p5-IO-Interface>=0:net/p5-IO-Interface \ > libpcap>=0:net/libpcap > > CFLAGS+= -I${PREFIX}/include > LDFLAGS+= -L${PREFIX}/lib > > After the upgrade to 1.9.0 (pre-release) in ports you simply add: > > CFLAGS+= -DHAVE_PCAP_SETSAMPLING -DHAVE_PCAP_OPEN No this won't solve the issue, libpcap from ports isn't compiled with remote support. Antoine