From owner-cvs-src@FreeBSD.ORG Sat Mar 25 01:14:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 764E916A401; Sat, 25 Mar 2006 01:14:21 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C1A743D45; Sat, 25 Mar 2006 01:14:21 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2P1EK9n039760; Sat, 25 Mar 2006 01:14:21 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2P1EKCF039759; Sat, 25 Mar 2006 01:14:20 GMT (envelope-from peter) Message-Id: <200603250114.k2P1EKCF039759@repoman.freebsd.org> From: Peter Wemm Date: Sat, 25 Mar 2006 01:14:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/gcore elfcore.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Mar 2006 01:14:21 -0000 peter 2006-03-25 01:14:20 UTC FreeBSD src repository Modified files: usr.bin/gcore elfcore.c Log: Make gcore(1) 64 bit safe. It was trying to parse the /proc/*/map file using sscanf and truncating the start/end entries by writing them with a 32 bit int descriptor (%x). The upper bytes of the 64 bit vm_offset_t variables (for little endian machines) were uninitialized. For big endian machines, things would have been worse because it was storing the 32 bit value in the upper half of the 64 bit variable. I've changed it to use %lx and long types. That should work on all our platforms. Revision Changes Path 1.18 +3 -3 src/usr.bin/gcore/elfcore.c