From owner-cvs-all Thu Jan 11 11:53:25 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id BF1CC37B401; Thu, 11 Jan 2001 11:52:50 -0800 (PST) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f0BJqL112124; Thu, 11 Jan 2001 11:52:21 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200101111912.f0BJCfs36487@aslan.scsiguy.com> Date: Thu, 11 Jan 2001 11:52:46 -0800 (PST) From: John Baldwin To: "Justin T. Gibbs" Subject: Re: cvs commit: src/sys/alpha/alpha interrupt.c machdep.c mp_mac Cc: Bruce Evans , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Jake Burkholder , =?ISO-8859-1?Q?G=E9rard_Roudier?= Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 11-Jan-01 Justin T. Gibbs wrote: >>These variables are magic. A developer can find out that they are magic in >>on >>e >>of two ways: >> >>1) Use a special macro that acknowledges that they are magic, and have the >>compile break if they don't so that they know there is something they need to >>take into account. >> >>2) Go memorize all aforementioned headers to know that these variables are >>magic. > > There is no reason that for two to be the case. We are only talking > about a naming difference. Having the headers cleaned up is a different > argument. > >>I prefer the interface 1) for this. Do you prefer 2)? > > I prefer "curproc" to PCPU_GET(curproc). Curproc already tells me > that this variable must be per-cpu. How? And does witness_spin_check tell you this, or astpending? astpending wasn't even per-CPU before the first SMPng commit. How about common_tss? > -- > Justin -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message