From owner-svn-src-head@freebsd.org  Tue Feb 28 21:30:45 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDFCECF26D1;
 Tue, 28 Feb 2017 21:30:45 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id D2DE2911;
 Tue, 28 Feb 2017 21:30:45 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v1SLUiYS017237
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 28 Feb 2017 13:30:44 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id v1SLUiXU017236;
 Tue, 28 Feb 2017 13:30:44 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 28 Feb 2017 13:30:44 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Benjamin Kaduk <bjkfbsd@gmail.com>
Cc: Ravi Pokala <rpokala@mac.com>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 John Baldwin <jhb@freebsd.org>
Subject: Re: svn commit: r314373 - in head: . etc/defaults etc/rc.d
 lib/libc/regex share/man/man4/man4.i386 share/man/man5 sys/amd64/conf
 sys/boot/forth sys/compat/svr4 sys/conf sys/dev/streams sys/i386/conf sy...
Message-ID: <20170228213044.GK1044@FreeBSD.org>
References: <201702280514.v1S5EhPq060885@repo.freebsd.org>
 <1969312.3TTRqhLH9r@ralph.baldwin.cx>
 <A783EF14-114B-4547-9737-3BB13FCE5DC4@panasas.com>
 <20170228193605.GJ1044@FreeBSD.org>
 <CAJ5_RoDzO_1OkyJ=aZAHUDBXib882+a0fB0GvdQqnjUxkL6Arg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ5_RoDzO_1OkyJ=aZAHUDBXib882+a0fB0GvdQqnjUxkL6Arg@mail.gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Feb 2017 21:30:46 -0000

On Tue, Feb 28, 2017 at 01:39:12PM -0600, Benjamin Kaduk wrote:
B> > I don't think this deserves UPDATING entry, since it doesn't require
B> > any action from a person who updates from sources.
B> >
B> > I don't think this requires __FreeBSD_version bump, since the latter
B> > is used to assist compilation of open source application that use
B> > changed API. The change removed support to run binaries.
B> >
B> 
B> That is not the only use of __FreeBSD_version, which is (at least) exposed
B> to the ports collection and can cause conditional changes in what are
B> shipped by ports.
B> Which is not to say that any current ports ship affected binaries, of
B> course, but just to point out that the scope of the symbol is broader than
B> stated.

How can I check the __FreeBSD_version in a port Makefile? My understanding
is that there is no standard way for such thing. Of course I can parse
/usr/include/sys/param.h...

My understanding is that the constant is for sources only:

https://www.freebsd.org/doc/en/books/porters-handbook/porting-versions.html

-- 
Totus tuus, Glebius.