From owner-svn-src-head@FreeBSD.ORG  Wed Oct  1 20:16:53 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C9CE5AF5
 for <svn-src-head@freebsd.org>; Wed,  1 Oct 2014 20:16:53 +0000 (UTC)
Received: from mail-qc0-f172.google.com (mail-qc0-f172.google.com
 [209.85.216.172])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 89A31FC9
 for <svn-src-head@freebsd.org>; Wed,  1 Oct 2014 20:16:53 +0000 (UTC)
Received: by mail-qc0-f172.google.com with SMTP id o8so1078847qcw.31
 for <svn-src-head@freebsd.org>; Wed, 01 Oct 2014 13:16:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=cJThrLAmqxL/Ddpo/3IF3nLaHQ7qvQNVKSsZFW7dZqo=;
 b=GhP2OFT1IEjPIJU//NXoRutWZn8yY6UwPJrJJgIXaEOD31/xsa9xxbKxxIjXIQhJFi
 v/MV8O6UImLZiKvmDMz5sTTs8SgpCROPeyzBKgChU3dj+kkxb4EqcC5D3CGBkh5f5u8b
 Gqghr8PXZp5XxS6Td5rSp+20pJDWW7gDW4ZwtyIaEP+lHvulHR/ffEGL2PSOkRkUqYZg
 ZhQ2Ql7MF4Zz7adAQo+XcubjNLtC5USX2bYFkLHfjlNQdKTis4WNQn6SPdsZgbBzBJoO
 BIbfw21dVbjidDsUUU4lgu3F/rwkPQc2pVQurGqBc6moc68HwSKRYE3a8DT3AcsuIhB7
 4y0w==
X-Gm-Message-State: ALoCoQnWfVwerGrDor1eOEBUXA1bnr8EqU2QosDF3pLb4XluV7bLmz0Cq0KmL2qHIdXC9h9ZIiiV
MIME-Version: 1.0
X-Received: by 10.224.127.131 with SMTP id g3mr35814371qas.81.1412194612640;
 Wed, 01 Oct 2014 13:16:52 -0700 (PDT)
Received: by 10.140.31.36 with HTTP; Wed, 1 Oct 2014 13:16:52 -0700 (PDT)
In-Reply-To: <CAGHfRMB81gj1k3UPLR0yd7StGBmJPUG1eXRLsVYxbxEqnoSECg@mail.gmail.com>
References: <201409291505.s8TF5Nhh066884@svn.freebsd.org>
 <CAGHfRMB81gj1k3UPLR0yd7StGBmJPUG1eXRLsVYxbxEqnoSECg@mail.gmail.com>
Date: Wed, 1 Oct 2014 14:16:52 -0600
Message-ID: <CADBaqmgG07ZLkb4d8_wLtf2+1xd164j0=AsWooPd-Y0LfnDb1w@mail.gmail.com>
Subject: Re: svn commit: r272282 - head/share/mk
From: Will Andrews <will@firepipe.net>
To: NGie Cooper <yaneurabeya@gmail.com>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Oct 2014 20:16:53 -0000

On Wed, Oct 1, 2014 at 2:03 PM, NGie Cooper <yaneurabeya@gmail.com> wrote:
> This change seems like it introduces a lot of unnecessary complexity
> in lieu of someone setting PORTSDIR to the root of their ports tree in
> the environment.

Sure, but people that are trying to use it somewhere other than
/usr/ports shouldn't be surprised by misbehavior.  I've worked with
several people (who aren't steeped in the usage of ports) who were
astonished by this behavior.

> Why isn't it using a for-loop by the way?

My original implementation used a shell for loop (see the CR), but
given the lack of a legitimate use case for looking farther up than
three parent directories, it seemed easier not to.  I suppose one
could use a static list of paths in the for loop though.

--Will.