From owner-svn-src-all@FreeBSD.ORG Thu Jun 24 02:31:23 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58DD5106564A; Thu, 24 Jun 2010 02:31:23 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B984D8FC13; Thu, 24 Jun 2010 02:31:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o5O2Qbv6001822; Wed, 23 Jun 2010 20:26:37 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 23 Jun 2010 20:26:47 -0600 (MDT) Message-Id: <20100623.202647.867924114552092597.imp@bsdimp.com> To: xcllnt@mac.com From: "M. Warner Losh" In-Reply-To: <3659E546-80A0-4E82-8112-40B093728D81@mac.com> References: <201006232326.o5NNQEtK011793@svn.freebsd.org> <3659E546-80A0-4E82-8112-40B093728D81@mac.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, nwhitehorn@freebsd.org Subject: Re: svn commit: r209490 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2010 02:31:23 -0000 In message: <3659E546-80A0-4E82-8112-40B093728D81@mac.com> Marcel Moolenaar writes: : : On Jun 23, 2010, at 4:26 PM, Nathan Whitehorn wrote: : : > @@ -53,7 +53,7 @@ __FBSDID("$FreeBSD$"); : > */ : > : > #ifndef HZ : > -# if defined(__amd64__) || defined(__i386__) || defined(__ia64__) || defined(__sparc64__) : > +# if defined(__amd64__) || defined(__i386__) || defined(__ia64__) || defined(__sparc64__) || defined(__powerpc__) : > # define HZ 1000 : > # else : > # define HZ 100 : : Would you mind inverting the #if statement? The common case is : obviously 1KHz, so listing the exceptions (I belief that's only : arm and mips) is more effective... Shouldn't this be defined in some file in ARCH/include instead? Warner