From owner-cvs-all Tue Dec 18 14:29:48 2001 Delivered-To: cvs-all@freebsd.org Received: from emmi.physik.TU-Berlin.DE (emmi.physik.TU-Berlin.DE [130.149.160.103]) by hub.freebsd.org (Postfix) with ESMTP id A14E237B41B; Tue, 18 Dec 2001 14:29:39 -0800 (PST) Received: (from ibex@localhost) by emmi.physik.TU-Berlin.DE (8.11.6/8.11.6) id fBIMTYx49846; Tue, 18 Dec 2001 23:29:34 +0100 (CET) (envelope-from ibex) Date: Tue, 18 Dec 2001 23:29:34 +0100 From: Dirk Froemberg To: Sergei Golubchik Cc: Maxim Sobolev , John Baldwin , cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: ports/databases/mysql323-server Makefile Message-ID: <20011218232934.D42190@physik.TU-Berlin.DE> References: <1008630359.5329.2.camel@notebook> <20011218194420.A31061@serg.mysql.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011218194420.A31061@serg.mysql.com>; from sergii@pisem.net on Tue, Dec 18, 2001 at 07:44:20PM +0000 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi! On Tue, Dec 18, 2001 at 07:44:20PM +0000, Sergei Golubchik wrote: > I would like to jump in as these options were taken > from our script. > > On Dec 18, Maxim Sobolev wrote: > > On Tue, 2001-12-18 at 00:53, John Baldwin wrote: > > > On 17-Dec-01 Dirk Froemberg wrote: > > > > dirk 2001/12/17 14:50:46 PST > ... > > > > - add BUILD_OPTIMIZED to add -mcpu=pentiumpro -O3 -fno-omit-frame-pointer > > > > to CFLAGS (and thus to CXXFLAGS) > > > > > > You should not use -O3, it is known to produce buggy code. Use -O only, not > > > even -O2. > > > > I agree with John - we should discourage anything above -O, not to > > encourage it. Especially this applies to the databases, when the buggy > > compiler output could do a lot of damage to the user's data. I think > > BUILD_OPTIMIZED should be removed. > > Generally I agree. And I do prefer the program that works slow > to the program that crashes fast. > > But these options were takes from the script that we (at MySQL AB) > use to generate our official binaries. Every possible precausion > is taken to ensure that our binaries are as stable is possible. > > So, -O3 is, most probably, very safe here. Thanks! I think the best would be a warning for BUILD_STATIC, then. Regards Dirk -- Dirk Froemberg FreeBSD: The Power to Serve! http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message