From owner-freebsd-net@FreeBSD.ORG  Mon Aug 29 00:08:54 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F0443106566C;
	Mon, 29 Aug 2011 00:08:54 +0000 (UTC)
	(envelope-from lstewart@freebsd.org)
Received: from lauren.room52.net (lauren.room52.net [210.50.193.198])
	by mx1.freebsd.org (Postfix) with ESMTP id B12CF8FC13;
	Mon, 29 Aug 2011 00:08:54 +0000 (UTC)
Received: from lstewart-laptop.caia.swin.edu.au
	(ppp59-167-184-191.static.internode.on.net [59.167.184.191])
	by lauren.room52.net (Postfix) with ESMTPSA id 76D4A7E824;
	Mon, 29 Aug 2011 10:08:52 +1000 (EST)
Message-ID: <4E5AD893.7010708@freebsd.org>
Date: Mon, 29 Aug 2011 10:08:51 +1000
From: Lawrence Stewart <lstewart@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:5.0) Gecko/20110727 Thunderbird/5.0
MIME-Version: 1.0
To: Steven Hartland <killing@multiplay.co.uk>
References: <E18D678F05BB4F3B93ADEB304CCA8504@multiplay.co.uk><1F95A4C2D54E4F369830143CBDB5FF86@multiplay.co.uk><4E37C0F2.4080004@freebsd.org><2B063B6D95AA4C27B004C50D96393F91@multiplay.co.uk><C706DEE346684B8DB06CFC090F556E72@multiplay.co.uk><4E3AA66A.6060605@freebsd.org><20229216858044E4881642284F245750@multiplay.co.uk>
	<4E432CB2.3030700@freebsd.org>
	<177917182AAD46A3962139F22B835B37@multiplay.co.uk>
In-Reply-To: <177917182AAD46A3962139F22B835B37@multiplay.co.uk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
	autolearn=unavailable version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lauren.room52.net
Cc: freebsd-net@freebsd.org, Andre Oppermann <andre@freebsd.org>,
	slw@zxy.spb.ru
Subject: Re: tcp failing to recover from a packet loss under 8.2-RELEASE?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Aug 2011 00:08:55 -0000

On 08/14/11 23:53, Steven Hartland wrote:
> ----- Original Message ----- From: "Lawrence Stewart"
> <lstewart@freebsd.org>
>>
>> Here's my tweaked version of Andre's patch:
>> http://people.freebsd.org/~lstewart/patches/misctcp/tcp_reass.c-logdebug%2bmissingsegment-20110811-lstewart.diff
>>
>
> Still testing this and just noticed that the patch fails to
> compile when INVARIANTS is enabled. The KASSERT calls need
> ()'s around the split strings.

oops, sorry. Compile tested on 8-STABLE without INVARIANTS enabled :/

Any further feedback with respect to the patch? Plan to submit it to re@ 
later this week for inclusion in 9.0.

Cheers,
Lawrence