From owner-dev-commits-ports-all@freebsd.org Tue Sep 14 12:06:58 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 916DF667DFA; Tue, 14 Sep 2021 12:06:58 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mail.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H82C5160mz3vPg; Tue, 14 Sep 2021 12:06:56 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1631621209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gHbN4QEAHJgQhFnS5ZTKIxveN7GstyXuIdnBn/kou5Q=; b=cxSS0Zc9DdpVWmJf5/4CgmG4ucRlktRbo0Ubg5vADwGAH/tWvW8C2nWhJKc12S5JuoWyG5 Os1fazDADu+xir0O754/gKiwzlcfHFkhH9RflwQgIrfjiAqxIKHasqbdAvMVs2BFOZYpmK qVtS25WE7UrwmqIMZE8J9eS7yVatL1o= Received: from amy (lfbn-idf2-1-644-191.w86-247.abo.wanadoo.fr [86.247.100.191]) by mx.blih.net (OpenSMTPD) with ESMTPSA id c206a95b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 14 Sep 2021 12:06:49 +0000 (UTC) Date: Tue, 14 Sep 2021 14:06:48 +0200 From: Emmanuel Vadot To: Jan Beich Cc: Emmanuel Vadot , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 4f3befc2a362 - main - ports-mgmt/pkg-devel: Add an option for building with sanitizer Message-Id: <20210914140648.73654736944b31545473f311@bidouilliste.com> In-Reply-To: References: <202109141010.18EAA5Yb091282__26781.7482979567$1631614221$gmane$org@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4H82C5160mz3vPg X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=cxSS0Zc9; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-3.35 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; ARC_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[bidouilliste.com:+]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-0.85)[-0.855]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 12:06:58 -0000 On Tue, 14 Sep 2021 13:51:18 +0200 Jan Beich wrote: > Emmanuel Vadot writes: > > > -OPTIONS_DEFINE= DOCS > > +OPTIONS_DEFINE= DOCS SAN > > +SAN_DESC= Enable sanitizers (ASAN and UBSAN) > > FWIW, other ports use different option name: > > net-p2p/c-lightning/Makefile > 38:ASAN_CONFIGURE_ENABLE= address-sanitizer > 39:ASAN_DESC= Compile with address-sanitizer > > security/snort3/Makefile > 35:ADDRESSSANITIZER_DESC= Enable address sanitizer > 44:ADDRESSSANITIZER_CMAKE_BOOL= ENABLE_ADDRESS_SANITIZER > 41:THREADSANITIZER_DESC= Enable thread sanitizer > 54:THREADSANITIZER_CMAKE_BOOL= ENABLE_THREAD_SANITIZER Yes but this activate all sanitizer supported by pkg (asan and ubsan for now) not just asan. > > > > +.if ${PORT_OPTIONS:MSAN} > > +CONFIGURE_ARGS+= --with-asan --with-ubsan > > +.endif > > With option helpers it can be more declarative e.g., > > SAN_CONFIGURE_WITH= asan ubsan Didn't knew that, will fix this later. -- Emmanuel Vadot