Date: Thu, 14 Feb 2019 11:28:44 -0800 From: John Baldwin <jhb@FreeBSD.org> To: rgrimes@freebsd.org, Eric Joyner <erj@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344132 - head/sys/dev/ixl Message-ID: <9b32ae9a-3cca-3529-fb65-96026a14dbbd@FreeBSD.org> In-Reply-To: <201902141822.x1EIMjPk087175@pdx.rh.CN85.dnsmgr.net> References: <201902141822.x1EIMjPk087175@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/14/19 10:22 AM, Rodney W. Grimes wrote: >> Author: erj >> Date: Thu Feb 14 18:02:37 2019 >> New Revision: 344132 >> URL: https://svnweb.freebsd.org/changeset/base/344132 >> >> Log: >> ixl: Fix panic caused by bug exposed by r344062 >> >> Don't use a struct if_irq for IFLIB_INTR_IOV type interrupts since that results >> in get_core_offset() being called on them, and get_core_offset() doesn't >> handle IFLIB_INTR_IOV type interrupts, which results in an assert() being triggered >> in iflib_irq_set_affinity(). >> >> PR: 235730 >> Reported by: Jeffrey Pieper <jeffrey.e.pieper@intel.com> >> MFC after: 1 day > > Normally you would request an RE@ approval for a fast track to stable, > consider this message such an approval. That does not match our historical practice over the past 20 years. If we want to change that practice, that's a topic we can debate, but re@ has only required oversight on MFC's during slushes/freezes with the additional caveat of perhaps watching out for ABI breakage at any time (and requiring approvals for a known ABI breakage on a branch). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9b32ae9a-3cca-3529-fb65-96026a14dbbd>