From owner-svn-src-all@FreeBSD.ORG  Wed May 29 17:58:45 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 97376415;
 Wed, 29 May 2013 17:58:45 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-qe0-f54.google.com (mail-qe0-f54.google.com
 [209.85.128.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2B546D33;
 Wed, 29 May 2013 17:58:44 +0000 (UTC)
Received: by mail-qe0-f54.google.com with SMTP id i11so5372524qej.27
 for <multiple recipients>; Wed, 29 May 2013 10:58:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=OGayFVCphYUme3bF5MJIJUURSvf0rWwlV8nmi5ywoag=;
 b=eFwh8pjhyQP8ZU6qrjzorezXobXRdwClIcQAZTU0TpGM+FYdpeDRPfHJEZxIZxaYAo
 fI7Q96mX2Bp2Gd+AejicjEn02yygG+FrckH9UIdBN6Oqe2Eew55NPVwB++mZg7jQubBs
 Fh4rT3q3YeAj/we4VBxtEyv11u9+PHMhe2un6EGMDijjbncxcQYDq9jPgivX3EwZkzD2
 sF1N8V6iM7znQF/mANsoa6M3u39NU3onfx3I2A3DOtfl2b/X0H8tb5ptHs+qucs0TnxQ
 yCHuchoGNiSoIGwrD6gC58am0w7KvYOwHJf7kWoILkSaTcdbqWk4fHMm73hQmqvKdM8r
 19yQ==
MIME-Version: 1.0
X-Received: by 10.224.52.212 with SMTP id j20mr4187754qag.64.1369850324434;
 Wed, 29 May 2013 10:58:44 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.224.199.66 with HTTP; Wed, 29 May 2013 10:58:44 -0700 (PDT)
In-Reply-To: <51A5E4DE.5060007@FreeBSD.org>
References: <201305290421.r4T4LgRc099595@svn.freebsd.org>
 <51A5E4DE.5060007@FreeBSD.org>
Date: Wed, 29 May 2013 10:58:44 -0700
X-Google-Sender-Auth: Cgchrs8qADglhFfA0EPufdgnb2U
Message-ID: <CAJ-VmokXGy96u6QUsu7CDoGyR5zAQZN7yobUFFZds8xfrmUmEA@mail.gmail.com>
Subject: Re: svn commit: r251098 - head/sys/contrib/dev/ath/ath_hal/ar9300
From: Adrian Chadd <adrian@freebsd.org>
To: Dimitry Andric <dim@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2013 17:58:45 -0000

No, it actually failed to compile at all on some older 9-stable laptops..

Hence my confusion.


Adrian

On 29 May 2013 04:22, Dimitry Andric <dim@freebsd.org> wrote:
> On 2013-05-29 06:21, Adrian Chadd wrote:
>>
>> Author: adrian
>> Date: Wed May 29 04:21:42 2013
>> New Revision: 251098
>> URL: http://svnweb.freebsd.org/changeset/base/251098
>>
>> Log:
>>    Fix a false -> AH_FALSE.
>>
>>    Now, why this hasn't tripped _any_ tinderbox builds yet, I dunno.
>>    It's been like this for a while.
>
>
> Because 'false' will be implicitly converted to an enum HAL_BOOL value.
> Adding a warning for such cases would result in a *lot* of noise, and
> probably many angry developers. ;-)
>
> Note that in C++, such a call would result in an error: "no known
> conversion from 'bool' to 'HAL_BOOL'".
>