From owner-cvs-src@FreeBSD.ORG Fri Apr 23 20:52:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E12616A4CE; Fri, 23 Apr 2004 20:52:19 -0700 (PDT) Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F05743D48; Fri, 23 Apr 2004 20:52:19 -0700 (PDT) (envelope-from alc@cs.rice.edu) Received: from localhost (calypso.cs.rice.edu [128.42.1.127]) by cs.rice.edu (Postfix) with ESMTP id E06FD4AC09; Fri, 23 Apr 2004 22:52:18 -0500 (CDT) Received: from cs.rice.edu ([128.42.1.30]) by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024) with LMTP id 08660-01-46; Fri, 23 Apr 2004 22:52:18 -0500 (CDT) Received: by cs.rice.edu (Postfix, from userid 19572) id 624CF4ABAF; Fri, 23 Apr 2004 22:52:18 -0500 (CDT) Date: Fri, 23 Apr 2004 22:52:18 -0500 From: Alan Cox To: Alan Cox Message-ID: <20040424035218.GI5199@cs.rice.edu> References: <200404240346.i3O3kipl055272@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200404240346.i3O3kipl055272@repoman.freebsd.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Apr 2004 03:52:19 -0000 On Fri, Apr 23, 2004 at 08:46:44PM -0700, Alan Cox wrote: > alc 2004/04/23 20:46:44 PDT > > FreeBSD src repository > > Modified files: > sys/vm vm_map.c vm_map.h > Log: > In cases where a file was resident in memory mmap(..., PROT_NONE, ...) > would actually map the file with read access enabled. According to > http://www.opengroup.org/onlinepubs/007904975/functions/mmap.html this is > an error. Similarly, an madvise(..., MADV_WILLNEED) would enable read > access on a virtual address range that was PROT_NONE. > > The solution implemented herein is (1) to pass a vm_prot_t to > vm_map_pmap_enter() describing the allowed access and (2) to make > vm_map_pmap_enter() responsible for understanding the limitations of > pmap_enter_quick(). > > Submitted by: "Mark W. Krentel" > PR: kern/64573 > > Revision Changes Path > 1.333 +5 -4 src/sys/vm/vm_map.c > 1.109 +1 -1 src/sys/vm/vm_map.h Could someone else please port and commit this change to RELENG_4? I'm happy to explain what to do. Thanks, Alan