From owner-svn-ports-head@FreeBSD.ORG Mon Oct 6 06:34:44 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E3C85EF7; Mon, 6 Oct 2014 06:34:44 +0000 (UTC) Received: from mail-oi0-x229.google.com (mail-oi0-x229.google.com [IPv6:2607:f8b0:4003:c06::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7D10E77E; Mon, 6 Oct 2014 06:34:44 +0000 (UTC) Received: by mail-oi0-f41.google.com with SMTP id u20so3183690oif.14 for ; Sun, 05 Oct 2014 23:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=2n960n7LsgZAnP5sI1VilLFyfL+5kJDJY35/SxLgiXk=; b=bSY4he1LSAKII8tZaoqZoEOdcRntKSqwVXCoP0SA7ArZOmWKk7eXYqihF9ZvTR05He GaobmglqbwCkFmN7kKDS1v1pUlXNnXHV2qzO2vCIZ3/Pt4TyugjR1BfZ6WHd5JlxnpmO DH/DAUluihiEM07OUDhiPmrk6uglBFO9dYW1FAQW2f8PJ9++O0TBIfbnmaIkOK5UQp0e aSuCeuwmLiBkj4lm3/FrOxM7tYUI4Sg0SFcF+OuXuLVe05BJDc4mX1YjRWNEkGbNGg3x eXv4bMAYuuwBoZSfjo+h1fKH3O+ycUA8Kha264iZAt7XaPBkU7DQ769UiQGTPk2y5mql LLHg== MIME-Version: 1.0 X-Received: by 10.182.33.66 with SMTP id p2mr23721199obi.51.1412577283835; Sun, 05 Oct 2014 23:34:43 -0700 (PDT) Sender: andrej.zverev@gmail.com Received: by 10.182.73.233 with HTTP; Sun, 5 Oct 2014 23:34:43 -0700 (PDT) In-Reply-To: <54323187.7040603@marino.st> References: <201410052140.s95LeUa9030114@svn.freebsd.org> <54323187.7040603@marino.st> Date: Mon, 6 Oct 2014 10:34:43 +0400 X-Google-Sender-Auth: azl58jd18vXls7FIYOP5aYWthks Message-ID: Subject: Re: svn commit: r370131 - in head/net-mgmt: . nagios-check_dhcp.pl From: Andrej Zverev To: John Marino Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Bartek Rutkowski , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 06:34:45 -0000 Hello John, I don't see why shebangfix can't handle space. _SHEBANG_REINPLACE_ARGS+= -e "1s|^\#![[:space:]]*${${lang}_OLD_CMD}|\#!${${lang}_CMD}|" Even if it can't you can make some handwork to obey framework instead of making one more way of doing this :-) About approval, well I first wanted to write my email to Robak and his mentrors, but after looking previous commits in my mailbox can't find any sign of them. Sure I know where to look. In this case I was too lazy to search, my fault. But anyway, what about LOCALBASE and shebangfix? I think they can be fixed. If you prefer I can provide patch. Please don't get my email as something bad, If something can be done better so why not. On Mon, Oct 6, 2014 at 10:07 AM, John Marino wrote: > On 10/6/2014 05:35, Andrej Zverev wrote: > > 2. @${REINPLACE_CMD} -e "s,/usr/bin/perl,${PERL}," ${WRKSRC}/${PORTNAME} > > <- you can use USES=shebangfix > > Be careful with this one -- I made a similar comment and then found out > the script started with "#! /usr/bin/perl" where the space prevented > shebangfix from working. This could be a similar situation. > > > P.S. Approved by: mentors (implicit) <- not sure about this they both > > did it, or only one of them and why don't write who they are? > > Robak has implicit approval from both mentors for most commits. He's > been given guidelines on when he should seek explicit approval. I'd > says "mentors" (plural) is appropriate. > > As for why not written, dunno. Obviously it can be looked up. I think > the key message is that explicit approval was not obtained, not > repeating who the mentors are which each commit (which doesn't change). > As one of his mentors, I didn't have a problem with the message. >