From owner-freebsd-bugs@FreeBSD.ORG Tue Dec 13 21:00:17 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED8D016A41F for ; Tue, 13 Dec 2005 21:00:16 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF73B43D5C for ; Tue, 13 Dec 2005 21:00:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id jBDL0Fi3005094 for ; Tue, 13 Dec 2005 21:00:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id jBDL0E3W005072; Tue, 13 Dec 2005 21:00:14 GMT (envelope-from gnats) Resent-Date: Tue, 13 Dec 2005 21:00:14 GMT Resent-Message-Id: <200512132100.jBDL0E3W005072@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gavin Atkinson Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BB3516A420 for ; Tue, 13 Dec 2005 20:55:35 +0000 (GMT) (envelope-from ga9@945testbox.york.ac.uk) Received: from mail-gw1.york.ac.uk (mail-gw1.york.ac.uk [144.32.128.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 394FE43D80 for ; Tue, 13 Dec 2005 20:55:34 +0000 (GMT) (envelope-from ga9@945testbox.york.ac.uk) Received: from 945testbox.york.ac.uk (945testbox.york.ac.uk [144.32.227.28]) by mail-gw1.york.ac.uk (8.12.10/8.12.10) with ESMTP id jBDKtVNW023696 for ; Tue, 13 Dec 2005 20:55:31 GMT Received: from 945testbox.york.ac.uk (localhost [127.0.0.1]) by 945testbox.york.ac.uk (8.13.4/8.13.4) with ESMTP id jBDKtWim004570 for ; Tue, 13 Dec 2005 20:55:33 GMT (envelope-from ga9@945testbox.york.ac.uk) Received: (from root@localhost) by 945testbox.york.ac.uk (8.13.4/8.13.4/Submit) id jBDKtWrP004569; Tue, 13 Dec 2005 20:55:32 GMT (envelope-from ga9) Message-Id: <200512132055.jBDKtWrP004569@945testbox.york.ac.uk> Date: Tue, 13 Dec 2005 20:55:32 GMT From: Gavin Atkinson To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/90353: [patch] Incorrect usage() in atacontrol X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Gavin Atkinson List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2005 21:00:17 -0000 >Number: 90353 >Category: bin >Synopsis: [patch] Incorrect usage() in atacontrol >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Dec 13 21:00:14 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Gavin Atkinson >Release: FreeBSD 7.0-CURRENT i386 >Organization: >Environment: System: FreeBSD 945testbox.york.ac.uk 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Mon Dec 12 18:04:02 GMT 2005 root@945testbox.york.ac.uk:/usr/obj/usr/src/sys/GENERIC i386 >Description: The help page printed out by atacontrol when arguments are incorrect is wrong in the definition of the "delete" command - it is used to delete arrays not channels, and therefore takes an array name as its argument rather than a channel. The man page is correct. >How-To-Repeat: Try to delete a channel, or an array. >Fix: --- atacontrol-delarray.diff begins here --- Index: src/sbin/atacontrol/atacontrol.c =================================================================== RCS file: /usr/cvs/src/sbin/atacontrol/atacontrol.c,v retrieving revision 1.37 diff -p -u -r1.37 atacontrol.c --- src/sbin/atacontrol/atacontrol.c 5 Aug 2005 13:08:02 -0000 1.37 +++ src/sbin/atacontrol/atacontrol.c 13 Dec 2005 20:50:23 -0000 @@ -103,7 +103,7 @@ usage() " atacontrol detach channel\n" " atacontrol reinit channel\n" " atacontrol create type [interleave] disk0 ... diskN\n" - " atacontrol delete channel\n" + " atacontrol delete array\n" " atacontrol addspare array disk\n" " atacontrol rebuild array\n" " atacontrol status array\n" --- atacontrol-delarray.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: