From owner-cvs-all@FreeBSD.ORG Mon Aug 23 18:04:02 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BAA616A4CE; Mon, 23 Aug 2004 18:04:02 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CB0643D77; Mon, 23 Aug 2004 18:04:02 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i7NI5JZO002657; Mon, 23 Aug 2004 11:05:19 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i7NI5JTj002656; Mon, 23 Aug 2004 11:05:19 -0700 Date: Mon, 23 Aug 2004 11:05:19 -0700 From: Brooks Davis To: Robert Watson Message-ID: <20040823180519.GC21483@odin.ac.hmc.edu> References: <4128673E.F68B68EE@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Md/poaVZ8hnGTzuv" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Andre Oppermann cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net rtsock.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2004 18:04:02 -0000 --Md/poaVZ8hnGTzuv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 22, 2004 at 10:51:13AM -0400, Robert Watson wrote: >=20 > On Sun, 22 Aug 2004, Andre Oppermann wrote: >=20 > > > Allow the size of the routing socket netisr queue to be configured = using > > > the tunable or sysctl 'net.route.netisr_maxqlen'. Default the maxi= mum > > > depth to 256 rather than IFQ_MAXLEN due to the downsides of dropping > > > routing messages. > > >=20 > > > MT5 candidate. > > >=20 > > > Discussed with: mdodd, mlaier, Vincent Jardin > >=20 > > A rtmessage should never ever be dropped. That would wedge the > > synchronized state of any userland routing daemons.=20 >=20 > That as may be, but we've always been able to drop them when the routing > socket socket buffers fill, or when are unable to allocate an mbuf due to > low memory, as we're often unable to block when such a message is > generated. Inserting a netisr dispatch inserted a new bounded length > queue introduced another possible source of loss when the queue overflows. > I chatted with Bruce Simpson about this, and he observed that the way > routing daemons may/do address some of the potential loss is to set the > socket buffer receive size higher; this is not fail safe, however. I > asked the submitter of the issue what the highest watermark level for > socket buffers we'd seen in practice was, but I have not seen a response > to that. He suggested making the netisr queue depth for the routing > socket to be unlimited; I made it configurable but set what I think is a > fairly high default. Do you have any measurement of how deep that socket > buffer gets in practice on high volume routers?=20 It might be useful to add a RTM_FOOBAR (or similar :-) message to send when we are forced to drop a message. It's impossiable to be 100% certain we will never drop a message so having a mechanism to indicate that things have gone wrong could be useful. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Md/poaVZ8hnGTzuv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBKjHeXY6L6fI4GtQRAsO7AJ9sm1DsQc8QnTmA3puzBz5aXAYZpQCeJOBe +oICw6nL0ldaIsxlTPzj5ic= =mKij -----END PGP SIGNATURE----- --Md/poaVZ8hnGTzuv--