From owner-svn-src-head@freebsd.org Wed Apr 15 16:50:48 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 214592BBF25 for ; Wed, 15 Apr 2020 16:50:48 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 492SzB2YxRz45Cl for ; Wed, 15 Apr 2020 16:50:46 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi1-f178.google.com with SMTP id j16so14041649oih.10 for ; Wed, 15 Apr 2020 09:50:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=xMUNp5MfCvZefM3nNvz7WBRq8+kX/BjGo7u0XFBY8BU=; b=QnDwG6vI4IR6HHJqReja8V1mRsXG2Zu9Jc0taUoc/m5qb7gEgWNM+DLOTekSEsbG6J PpnEIPRLVZdxXoc1BdP3nxmaOhhbhpo++zeATWHNBbygO/1LNYmhwFliILtbpzP/IHqu bwMse8Pcv1HRQPICXixGA0FlVG77Tbvy2PM4s7TexfBk/8Y3iKKWChf8Ma+ukZPSQmTr 2Ae1G4kGL60/jq2goGCod3gtA2RJna2+xv7zOpMyp9wpO0ZG1kzTzrXhGXuOHJFm17+S 54mjQgrIq0Ntuay9AmrfQTvWB/AwjfviWFFEIzZ9lv9VCMzuHrExPuG5Z8MXl+rkIrPK 3ebw== X-Gm-Message-State: AGi0Pubr/7pFHkTQDgGWE1WDq81mQZz/qEOQZaWFztobRdFCjoA0+q2b FXd8Y2AaeIO/RGU/u91PVuCByX71 X-Google-Smtp-Source: APiQypKg90YZWKzjICD5kyns56kRRdr6/GSDS+anjycn7g2kyO1tHpYep+XLyvhcnqcBwnCTHEhtUQ== X-Received: by 2002:aca:1107:: with SMTP id 7mr72569oir.133.1586969445082; Wed, 15 Apr 2020 09:50:45 -0700 (PDT) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com. [209.85.167.176]) by smtp.gmail.com with ESMTPSA id r28sm2523oij.22.2020.04.15.09.50.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2020 09:50:44 -0700 (PDT) Received: by mail-oi1-f176.google.com with SMTP id s202so10827871oih.3 for ; Wed, 15 Apr 2020 09:50:43 -0700 (PDT) X-Received: by 2002:aca:dc56:: with SMTP id t83mr117535oig.48.1586969443837; Wed, 15 Apr 2020 09:50:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 15 Apr 2020 09:50:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r359829 - in head/sys: amd64/conf conf To: Mark Millard Cc: svn-src-head@freebsd.org X-Rspamd-Queue-Id: 492SzB2YxRz45Cl X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-2.25 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; RCPT_COUNT_TWO(0.00)[2]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; FREEMAIL_TO(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[178.167.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.25)[ip: (-0.38), ipnet: 209.85.128.0/17(-0.40), asn: 15169(-0.43), country: US(-0.05)]; RWL_MAILSPIKE_POSSIBLE(0.00)[178.167.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2020 16:50:48 -0000 No. There is no dependency relationship between the two options. On Sun, Apr 12, 2020 at 12:43 Mark Millard wrote: > > Author: cem > > Date: Sun Apr 12 18:04:20 2020 > > New Revision: 359829 > > URL: > > https://svnweb.freebsd.org/changeset/base/359829 > > > > > > Log: > > Add queue(2) debug macros as build options > > > > Add QUEUE_MACRO_DEBUG_TRACE and QUEUE_MACRO_DEBUG_TRASH as proper > kernel > > options. While here, alpha-sort the debug section of sys/conf/options. > > > > Enable QUEUE_MACRO_DEBUG_TRASH in amd64 GENERIC (but not > GENERIC-NODEBUG) > > kernels. It is similar in nature and cost to other use-after-free > pointer > > trashing we do in GENERIC. It is probably reasonable to enable in any > arch > > GENERIC kernel that defines INVARIANTS. > > Going the other way: Is QUEUE_MACRO_DEBUG_TRASH unsafe when INVARIANTS > has been disabled? > > I historically produce non-debug/less-debug kernels via including GENERIC > and then disabling various debugging options, including frequently > disabling INVARIANTS and INVARIANTS_SUPPORT. > > Would the following be appropriate for the comments, with its extra > "required by" on the first line shown: > > options INVARIANTS # Enable calls of extra sanity > checking, required by QUEUE_MACRO_DEBUG_TRASH > options INVARIANT_SUPPORT # Extra sanity checks of internal > structures, required by INVARIANTS > options QUEUE_MACRO_DEBUG_TRASH # Trash queue(2) internal pointers > on invalidation > > Should head/sys/conf/NOTES have material about avoiding > QUEUE_MACRO_DEBUG_TRASH with INVARIANTS disabled? > > > > === > Mark Millard > marklmi at yahoo.com > ( dsl-only.net went > away in early 2018-Mar) > >