From owner-freebsd-current@FreeBSD.ORG Thu Jun 14 12:18:11 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7153B16A469 for ; Thu, 14 Jun 2007 12:18:11 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-3.cisco.com (sj-iport-3-in.cisco.com [171.71.176.72]) by mx1.freebsd.org (Postfix) with ESMTP id 45EAA13C46C for ; Thu, 14 Jun 2007 12:18:11 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-dkim-3.cisco.com ([171.71.179.195]) by sj-iport-3.cisco.com with ESMTP; 14 Jun 2007 05:17:46 -0700 X-IronPort-AV: i="4.16,420,1175497200"; d="scan'208"; a="494077951:sNHT161535892" Received: from sj-core-5.cisco.com (sj-core-5.cisco.com [171.71.177.238]) by sj-dkim-3.cisco.com (8.12.11/8.12.11) with ESMTP id l5ECHjLx004647; Thu, 14 Jun 2007 05:17:45 -0700 Received: from xbh-sjc-231.amer.cisco.com (xbh-sjc-231.cisco.com [128.107.191.100]) by sj-core-5.cisco.com (8.12.10/8.12.6) with ESMTP id l5ECHjtV016732; Thu, 14 Jun 2007 12:17:45 GMT Received: from xfe-sjc-212.amer.cisco.com ([171.70.151.187]) by xbh-sjc-231.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 14 Jun 2007 05:17:45 -0700 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-212.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 14 Jun 2007 05:17:44 -0700 Message-ID: <4671325C.9010707@cisco.com> Date: Thu, 14 Jun 2007 08:19:40 -0400 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070601 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <46706E63.1080906@cisco.com> <20070614022510.GA61989@rot13.obsecurity.org> <4670B1A0.4070706@cisco.com> <20070614055401.GA77538@rot13.obsecurity.org> In-Reply-To: <20070614055401.GA77538@rot13.obsecurity.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Jun 2007 12:17:44.0872 (UTC) FILETIME=[035A7280:01C7AE7E] DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=962; t=1181823465; x=1182687465; c=relaxed/simple; s=sjdkim3002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:=20Randall=20Stewart=20 |Subject:=20Re=3A=20KTR=20and=20SCTP |Sender:=20; bh=moz238NelGKOJs3RW/Nn5zEveeYhFcFc4Kh5WSH/fBg=; b=Tofl76FGjRwy/ZEIjVMINIU1ntHUbPQtnB2H+xGna09NDoDsiVztPBwdkY+757IkC9Pqbhgw 3xl7zboD/CEfUS92f/QUbXEaCMTGrwp/eLzWI7dvcdwjmFc2f5GesZ50; Authentication-Results: sj-dkim-3; header.From=rrs@cisco.com; dkim=pass (sig from cisco.com/sjdkim3002 verified; ); Cc: current@freebsd.org Subject: Re: KTR and SCTP X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2007 12:18:11 -0000 Kris Kennaway wrote: > On Wed, Jun 13, 2007 at 11:10:24PM -0400, Randall Stewart wrote: > > > > You can't use KTR_SPARE* in committed code either, or it's no longer > spare :) You should do something like: > > i.e. do something like > > #ifdef SCTP_TRACE > #define KTR_SCTP KTR_SUBSYS > #else > #define KTR_SCTP 0 > #endif > > see the comment in > > * Two of the trace classes (KTR_DEV and KTR_SUBSYS) are special in that > * they are really placeholders so that indvidual drivers and subsystems > * can map their internal tracing to the general class when they wish to > * have tracing enabled and map it to 0 when they don't. > Hmm.. can I use KTR_GEN? its one of the 6 unused ones (besides the SPARE1-5) and it would surely make it easier for the researchers that use SCTP and want to pull the info... :-) R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)