From owner-freebsd-bugs Tue Oct 31 10:10:03 1995 Return-Path: owner-bugs Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA13627 for bugs-outgoing; Tue, 31 Oct 1995 10:10:03 -0800 Received: (from gnats@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA13619 ; Tue, 31 Oct 1995 10:10:01 -0800 Date: Tue, 31 Oct 1995 10:10:01 -0800 Message-Id: <199510311810.KAA13619@freefall.freebsd.org> To: freebsd-bugs Cc: From: Luigi Rizzo Subject: Re: misc/804: fdformat - patch to add DOS-filsystem Reply-To: Luigi Rizzo Sender: owner-bugs@FreeBSD.org Precedence: bulk The following reply was made to PR misc/804; it has been noted by GNATS. From: Luigi Rizzo To: ah@alvman.robin.de Cc: FreeBSD-gnats-submit@freebsd.org, haakh%socrates@socrates.st.bauing.th-darmstadt.de Subject: Re: misc/804: fdformat - patch to add DOS-filsystem Date: Tue, 31 Oct 1995 19:01:28 +0100 (MET) > I added an option (-D) to write a dos-filesystem to the floppies. > The changes are based on msdosfs and mformat (mtools). hmmm... I don't like very much the idea of duplicating code (and possibly have to mantain multiple copies). Why don't you just make fdformat invoke mformat with the appropriate (possibly configurable) arguments ? This way, once mtools 2.XX (or hfstools or whatever) are upgraded to write a W95 (or HFS) filesystem, you get the new capabilities for free. Luigi ==================================================================== Luigi Rizzo Dip. di Ingegneria dell'Informazione email: luigi@iet.unipi.it Universita' di Pisa tel: +39-50-568533 via Diotisalvi 2, 56126 PISA (Italy) fax: +39-50-568522 http://www.iet.unipi.it/~luigi/ ====================================================================