Date: Mon, 15 Aug 2022 06:37:43 +0800 From: "Ben Woods" <woodsb02@freebsd.org> To: freebsd-net@freebsd.org Cc: "Hiroki Sato" <hrs@freebsd.org>, emaste@freebsd.org, "Roy Marples" <roy@marples.name>, brooks@freebsd.org, cy@freebsd.org, "Philip Paeps" <philip@freebsd.org> Subject: Re: Import dhcpcd(8) into FreeBSD base Message-ID: <b51d8464-1f86-48e3-8c4b-147223cd5e35@www.fastmail.com> In-Reply-To: <03de2ce0-b3ca-4dcb-a40b-1962fe740b44@www.fastmail.com> References: <e401671f-6a67-49ed-bc41-e8fbb9de27cb@www.fastmail.com> <20220807.232337.383956020917382126.hrs@FreeBSD.org> <4516f415-939e-6374-45ce-df19a2ac65cb@marples.name> <20220809.054039.722614217650843004.hrs@FreeBSD.org> <74a1d9c2-6eab-b685-e71e-7d69a6fe6a9f@marples.name> <03de2ce0-b3ca-4dcb-a40b-1962fe740b44@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 10 Aug 2022, at 8:46 AM, Ben Woods wrote: > > I agree with the plan also - Import dhcpcd with its dedicated rc.d=20 > script (build enabled with runtime off by default, but manually enable= d=20 > by dhcpcd_enable=3D=E2=80=9CYES=E2=80=9D). > > No need to change the rc or network.subr system for now, as dhclient=20 > and rtsold are already off by default (or if enabled by default will b= e=20 > possible to disable in rc.conf). > > No need to have plans to remove dhclient/rtsold now - let=E2=80=99s gi= ve people=20 > the option for now, with no plan to necessarily remove dhclient/rtsold. > > Hiroki - I=E2=80=99ll update my phabricator review to align with the a= bove. > > Regards, > Ben > > --=20 > From: Ben Woods > woodsb02@freebsd.org Ok, I believe I now have this in a state which is ready to land in FreeB= SD, and would welcome any comments before doing so. Also, as previously mentioned, I have a ports commit bit, so would need = a src committer to approve me committing or commit on my behalf. I have 2 differential reviews for this: https://reviews.freebsd.org/D36196 - Create vendor branch vendor/dhcpcd https://reviews.freebsd.org/D22012 - Import dhcpcd into FreeBSD base The first review is new, and I=E2=80=99m not sure if it is normal to rev= iew vendor branch creations, but at a minimum I need approval to do so. The second review has now been updated to remove any changes to rc scrip= ts other than adding the new=E2=80=A8/etc/rc.d/dhcpcd. It is built/insta= lled by default, but not run by default. Do people think there should be= a WITH_DHCPCD build knob (on by default) to allow it to not be built (e= .g. save space on embedded systems)? Regards, Ben --=20 From: Ben Woods woodsb02@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b51d8464-1f86-48e3-8c4b-147223cd5e35>