From owner-cvs-all@FreeBSD.ORG  Thu Dec  6 09:35:47 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C848216A418;
	Thu,  6 Dec 2007 09:35:47 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 5FD3613C474;
	Thu,  6 Dec 2007 09:35:47 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id DF59A17104;
	Thu,  6 Dec 2007 09:35:45 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id lB69Zjf7087895;
	Thu, 6 Dec 2007 09:35:45 GMT (envelope-from phk@critter.freebsd.dk)
To: John Baldwin <jhb@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Thu, 06 Dec 2007 04:21:17 EST."
	<200712060421.18367.jhb@freebsd.org> 
Date: Thu, 06 Dec 2007 09:35:45 +0000
Message-ID: <87894.1196933745@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: cvs-src@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>,
	src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/conf NOTES files options src/sys/geom/part
	g_part.c g_part.h g_part_bsd.c src/sys/ia64/conf DEFAULTS 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2007 09:35:47 -0000

In message <200712060421.18367.jhb@freebsd.org>, John Baldwin writes:
>On Wednesday 05 December 2007 09:32:42 pm Marcel Moolenaar wrote:

>>   Add a BSD disklabel backend to g_part:
>
>So one issue with gpart is it doesn't handle attribute requests yet,

A few other notes:

I was planning on removing the "change the partitioning by writing
through the 'c' partition" code in -current now, I trust that you
have not implemented that ?

You are aware of newfs trying to change the partition type.  I'm
not happy with how that is done and not really happy about it in
general, now that we have g_label.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.