From owner-svn-src-all@FreeBSD.ORG Wed Apr 14 17:44:32 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05E78106564A; Wed, 14 Apr 2010 17:44:32 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f214.google.com (mail-bw0-f214.google.com [209.85.218.214]) by mx1.freebsd.org (Postfix) with ESMTP id 162588FC29; Wed, 14 Apr 2010 17:44:30 +0000 (UTC) Received: by bwz6 with SMTP id 6so395518bwz.13 for ; Wed, 14 Apr 2010 10:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=lVUQafcY8476Z1Kn0v8PhQmShLbvS7DKHE5KCBl+FJg=; b=sPzt8DO64SGECq6ImzaEl+285cbiVcfWBjC6Y74YT597uz3ij/KV/zUIlHjXqVZuSe o79i3pi3ZbqGT4XmC7PAMlcGpqLJIISxgOPCagBlUOpeMqjBm0sBCYpRapojz8IHfuDH KvCzXZ6syPb5CzwLV4xM2C2RjlpX798R9kgg8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=dMFP+baJygbzjY1n02PbLPnGil0eMtVPFrYOhuhd2UtPs5KhJWG/gXmLdEifkyz0Lc 4SUgaHrIoAgI3y65GDoXH8MOgGEPZn3ojCw/WjXlrPqNWRRPxe9aejDUU+LYzGbreR24 KQzRiAH2Sg8Dwt4yV2FjXQZ5lYC/+6oHIQSo4= Received: by 10.103.76.26 with SMTP id d26mr4320175mul.115.1271267069479; Wed, 14 Apr 2010 10:44:29 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id i5sm3407341mue.19.2010.04.14.10.44.27 (version=SSLv3 cipher=RC4-MD5); Wed, 14 Apr 2010 10:44:28 -0700 (PDT) Sender: Alexander Motin Message-ID: <4BC5FEF3.2090801@FreeBSD.org> Date: Wed, 14 Apr 2010 20:44:19 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.24 (X11/20100402) MIME-Version: 1.0 To: Marius Strobl References: <201004141529.o3EFTWd9011506@svn.freebsd.org> <20100414170952.GA23301@alchemy.franken.de> In-Reply-To: <20100414170952.GA23301@alchemy.franken.de> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r206604 - head/sys/dev/ata/chipsets X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 17:44:32 -0000 Marius Strobl wrote: > On Wed, Apr 14, 2010 at 03:29:32PM +0000, Alexander Motin wrote: >> Author: mav >> Date: Wed Apr 14 15:29:32 2010 >> New Revision: 206604 >> URL: http://svn.freebsd.org/changeset/base/206604 >> >> Log: >> For early ALI chips do not announce I/O sizes that require unsupported >> 48bit DMA commands. > > Wouldn't it make more sense to limit the I/O size based ATA_NO_48BIT_DMA > in a central place rather than letting each chipset driver deal with it? This driver is the only place where this flag is set now. And looking that 48bit is almost mandatory now, unlikely it will be ever needed again. -- Alexander Motin