From owner-cvs-all Wed Mar 28 19: 3:25 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.viasoft.com.cn (unknown [61.153.1.177]) by hub.freebsd.org (Postfix) with ESMTP id 3EC4737B725; Wed, 28 Mar 2001 19:03:16 -0800 (PST) (envelope-from bsddiy@21cn.com) Received: from William ([192.168.1.98]) by mail.viasoft.com.cn (8.9.3/8.9.3) with ESMTP id LAA31809; Thu, 29 Mar 2001 11:00:42 +0800 Date: Thu, 29 Mar 2001 11:07:54 +0800 From: David Xu X-Mailer: The Bat! (v1.48f) Personal Organization: Viasoft X-Priority: 3 (Normal) Message-ID: <119005138.20010329110754@21cn.com> To: Yar Tikhiy Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_vlan.c In-reply-To: <200103281552.f2SFqGV17218@freefall.freebsd.org> References: <200103281552.f2SFqGV17218@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hello Yar, Wednesday, March 28, 2001, 11:52:16 PM, you wrote: YT> yar 2001/03/28 07:52:16 PST YT> Modified files: YT> sys/net if_vlan.c YT> Log: YT> Fix a number of minor bugs in the VLAN code: YT> * Initialize the "struct sockaddr_dl sdl" correctly in vlan_setmulti(). YT> PR: kern/22181 YT> * The driver used to call malloc(..., M_NOWAIT), but to not check the YT> return value. Change malloc(..., M_NOWAIT) to malloc(..., M_WAITOK) YT> because the corresponding part of code is called from the upper YT> half of the kernel only. YT> PR: kern/22181 YT> * Make sure a parent interface is up and running before invoking YT> its if_start() routine in order to avoid system panic. YT> PR: kern/22179 kern/24741 i386/25478 YT> * Do not copy all the flags from a parent mindlessly. YT> PR: kern/22179 YT> * Do not call if_down() on a parent interface if it's already down. YT> Call if_down() at splimp because if_down() needs that. YT> PR: kern/22179 YT> Reviewed by: wollman YT> Revision Changes Path YT> 1.26 +26 -7 src/sys/net/if_vlan.c hahaha, Excellent work! pls don't forget to MFC. -- Best regards, David Xu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message